[AI Assistant] Fix OpenAI, error race condition bug #205665
Merged
+108
−699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
release_note:fix
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
stephmilovic
commented
Jan 6, 2025
Comment on lines
+158
to
+159
| // if generation is null, an error occurred - do nothing and let error handling complete the stream | ||
| generation != null && |
There was a problem hiding this comment.
This check is the actual bug fix, the rest is cleanup to match the same syntax we're using for Bedrock/Gemini
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 7, 2025
(cherry picked from commit 2c70e86)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 7, 2025
…205767) # Backport This will backport the following commits from `main` to `8.x`: - [[AI Assistant] Fix OpenAI, error race condition bug (#205665)](#205665) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T15:12:20Z","message":"[AI Assistant] Fix OpenAI, error race condition bug (#205665)","sha":"2c70e8651e52966f7c47bedfcd898eeb23bc0b1e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Security Generative AI","v8.18.0"],"title":"[AI Assistant] Fix OpenAI, error race condition bug","number":205665,"url":"https://github.com/elastic/kibana/pull/205665","mergeCommit":{"message":"[AI Assistant] Fix OpenAI, error race condition bug (#205665)","sha":"2c70e8651e52966f7c47bedfcd898eeb23bc0b1e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205665","number":205665,"mergeCommit":{"message":"[AI Assistant] Fix OpenAI, error race condition bug (#205665)","sha":"2c70e8651e52966f7c47bedfcd898eeb23bc0b1e"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steph Milovic <[email protected]>
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition that caused generic errors to show some of the time in OpenAI. The actual fix is adding a condition to the
on_llm_endevent that does not callhandleStreamEndifgenerationsis undefined. This should only happen when there is an error. The error is caught inpost_actions_connector_execute.tsand reported tohandleStreamEnd.I changed the stream style to async iterator to match what we are doing in Bedrock/Gemini. This doesn't have to do with the fix, but makes the code a bit more readable.
To test
401 Incorrect API key provided. You should NOT see an error likeResponse from LLM API is empty or undefinedDeleted files
I deleted some files I discovered are no longer in use. This is also unrelated to the bug fix