Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [data.search] Clean up code around ES preference usage (#204076) #205661

Merged
merged 2 commits into from
Jan 7, 2025
Merged

[8.x] [data.search] Clean up code around ES preference usage (#204076) #205661

merged 2 commits into from
Jan 7, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@lukasolson
[data.search] Clean up code around ES preference usage (elastic#204076)
39b81f4 
## Summary

While refreshing my memory on how we are using the Elasticsearch
`preference` parameter, I noticed we had a method `getEsPreference` that
was exported but not used. We then had an additional method
`getPreference` that was being used to actually set the parameter. I
consolidated these into one place and moved the tests so that we can
utilize it when ES|QL supports this parameter.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Marco Vettorello <[email protected]>
(cherry picked from commit df3665f)
@kibanamachine kibanamachine enabled auto-merge (squash) January 6, 2025 22:11
@kibanamachine kibanamachine mentioned this pull request Jan 6, 2025
Merged
1 task
@kibanamachine kibanamachine merged commit b74ac18 into elastic:8.x Jan 7, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #18 / Cloud Security Posture Test adding Cloud Security Posture Integrations CNVM CNVM AWS Hyperlink on PostInstallation Modal should have the correct URL
  • [job] [logs] FTR Configs #62 / Observability onboarding API tests logs/environment.spec.ts basic Install shipper setup returns apiEndpoint and scriptDownloadUrl prioritizing server.publicBaseUrl

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 512 510 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2594 2593 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 417.7KB 417.6KB -91.0B
Unknown metric groups

API count

id before after diff
data 3209 3208 -1

History

cc @lukasolson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@lukasolson lukasolson

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @lukasolson