Remove inference_id field if no inference endpoint is selected #205660
+50
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samiul-TheSoccerFan
added
release_note:skip
Samiul-TheSoccerFan
force-pushed
the
fix-default-inference-endpoint
branch
from
0361868 to
6c02702
Compare
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
|
/ci |
mattkime
requested changes
Jan 9, 2025
| @@ -130,8 +131,9 @@ export const CreateField = React.memo(function CreateFieldComponent({ | |||
| const { isValid, data } = await form.submit(); | |||
|
|
|||
| if (isValid && !clickOutside) { | |||
| if (isSemanticTextField(data)) { | |||
| handleSemanticText(data); | |||
| if (isSemanticTextField(data) && isEmpty(data.inference_id)) { | |||
There was a problem hiding this comment.
It would be good to have unit tests around this assemblage of content.
sphilipse
approved these changes
Jan 16, 2025
| @@ -237,6 +238,7 @@ export const DetailsPageMappingsContent: FunctionComponent<{ | |||
| .map((field) => field.inference_id) | |||
| .filter( | |||
| (inferenceId: string) => | |||
| !isEmpty(inferenceId) && | |||
There was a problem hiding this comment.
You can just do !inferenceId, no need to import a lodash function that checks way more than is necessary.
| @@ -130,8 +131,9 @@ export const CreateField = React.memo(function CreateFieldComponent({ | |||
| const { isValid, data } = await form.submit(); | |||
|
|
|||
| if (isValid && !clickOutside) { | |||
| if (isSemanticTextField(data)) { | |||
| handleSemanticText(data); | |||
| if (isSemanticTextField(data) && isEmpty(data.inference_id)) { | |||
There was a problem hiding this comment.
No need for isEmpty, you can just do !data.inference_id
Samiul-TheSoccerFan
force-pushed
the
fix-default-inference-endpoint
branch
from
3f3e7c5 to
59fe360
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 20, 2025
…ic#205660) ## Summary Currently, the `semantic_text` field supports a default `inference_id`, meaning users are not required to explicitly select an inference endpoint during mapping. However, a bug has been identified: if the `Select inference Id` popover is not opened, the `inference_id` field property remains as an empty string. This causes Elasticsearch (ES) to throw an error, as it requires a value to be present if the property is defined. To address this issue, the proposed solution is to remove the `inference_id` property from the `semantic_text` field during field mapping if its value is empty. ### Screen Recording https://github.com/user-attachments/assets/e8d8d471-7ff2-493e-8872-e42838579d44 --------- Co-authored-by: Matthew Kime <[email protected]> (cherry picked from commit c8e0408)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 20, 2025
…205660) (#207189) # Backport This will backport the following commits from `main` to `8.x`: - [Remove inference_id field if no inference endpoint is selected (#205660)](#205660) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Samiul Monir","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-20T12:49:21Z","message":"Remove inference_id field if no inference endpoint is selected (#205660)\n\n## Summary\r\n\r\nCurrently, the `semantic_text` field supports a default `inference_id`,\r\nmeaning users are not required to explicitly select an inference\r\nendpoint during mapping. However, a bug has been identified: if the\r\n`Select inference Id` popover is not opened, the `inference_id` field\r\nproperty remains as an empty string. This causes Elasticsearch (ES) to\r\nthrow an error, as it requires a value to be present if the property is\r\ndefined.\r\n\r\nTo address this issue, the proposed solution is to remove the\r\n`inference_id` property from the `semantic_text` field during field\r\nmapping if its value is empty.\r\n\r\n### Screen Recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e8d8d471-7ff2-493e-8872-e42838579d44\r\n\r\n---------\r\n\r\nCo-authored-by: Matthew Kime <[email protected]>","sha":"c8e0408e71e4bdfde59a083833f73b4ef1eb6407","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","v9.0.0","ci:project-deploy-elasticsearch","backport:version","v8.18.0"],"title":"Remove inference_id field if no inference endpoint is selected","number":205660,"url":"https://github.com/elastic/kibana/pull/205660","mergeCommit":{"message":"Remove inference_id field if no inference endpoint is selected (#205660)\n\n## Summary\r\n\r\nCurrently, the `semantic_text` field supports a default `inference_id`,\r\nmeaning users are not required to explicitly select an inference\r\nendpoint during mapping. However, a bug has been identified: if the\r\n`Select inference Id` popover is not opened, the `inference_id` field\r\nproperty remains as an empty string. This causes Elasticsearch (ES) to\r\nthrow an error, as it requires a value to be present if the property is\r\ndefined.\r\n\r\nTo address this issue, the proposed solution is to remove the\r\n`inference_id` property from the `semantic_text` field during field\r\nmapping if its value is empty.\r\n\r\n### Screen Recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e8d8d471-7ff2-493e-8872-e42838579d44\r\n\r\n---------\r\n\r\nCo-authored-by: Matthew Kime <[email protected]>","sha":"c8e0408e71e4bdfde59a083833f73b4ef1eb6407"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205660","number":205660,"mergeCommit":{"message":"Remove inference_id field if no inference endpoint is selected (#205660)\n\n## Summary\r\n\r\nCurrently, the `semantic_text` field supports a default `inference_id`,\r\nmeaning users are not required to explicitly select an inference\r\nendpoint during mapping. However, a bug has been identified: if the\r\n`Select inference Id` popover is not opened, the `inference_id` field\r\nproperty remains as an empty string. This causes Elasticsearch (ES) to\r\nthrow an error, as it requires a value to be present if the property is\r\ndefined.\r\n\r\nTo address this issue, the proposed solution is to remove the\r\n`inference_id` property from the `semantic_text` field during field\r\nmapping if its value is empty.\r\n\r\n### Screen Recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e8d8d471-7ff2-493e-8872-e42838579d44\r\n\r\n---------\r\n\r\nCo-authored-by: Matthew Kime <[email protected]>","sha":"c8e0408e71e4bdfde59a083833f73b4ef1eb6407"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Samiul Monir <[email protected]>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 21, 2025
…ic#205660) ## Summary Currently, the `semantic_text` field supports a default `inference_id`, meaning users are not required to explicitly select an inference endpoint during mapping. However, a bug has been identified: if the `Select inference Id` popover is not opened, the `inference_id` field property remains as an empty string. This causes Elasticsearch (ES) to throw an error, as it requires a value to be present if the property is defined. To address this issue, the proposed solution is to remove the `inference_id` property from the `semantic_text` field during field mapping if its value is empty. ### Screen Recording https://github.com/user-attachments/assets/e8d8d471-7ff2-493e-8872-e42838579d44 --------- Co-authored-by: Matthew Kime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the
semantic_textfield supports a defaultinference_id, meaning users are not required to explicitly select an inference endpoint during mapping. However, a bug has been identified: if theSelect inference Idpopover is not opened, theinference_idfield property remains as an empty string. This causes Elasticsearch (ES) to throw an error, as it requires a value to be present if the property is defined.To address this issue, the proposed solution is to remove the
inference_idproperty from thesemantic_textfield during field mapping if its value is empty.Screen Recording
default-elser.mov