Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Remove Enterprise Search UI Apps #205634

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Search] Remove Enterprise Search UI Apps #205634

wants to merge 7 commits into from
+3 −127,531

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Jan 6, 2025 •
edited
Loading

Summary

Removing app search & workplace search kibana applications from enterprise_search plugin. This will be the first of many PRs to remove code related to the enterprise search node.

Checklist

  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:Search labels Jan 6, 2025
@TattdCodeMonkey TattdCodeMonkey marked this pull request as ready for review January 6, 2025 19:09
@TattdCodeMonkey TattdCodeMonkey requested review from a team as code owners January 6, 2025 19:09
@TattdCodeMonkey
Copy link
Contributor Author

@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner January 7, 2025 15:12
sphilipse
sphilipse approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TattdCodeMonkey
search: remove App Search & Workplace Search FTRs
dafd5c0 
Removing the Accessibility FTRs for App Search & Workplace Search since
we're removing these UI Kibana Apps
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

@TattdCodeMonkey TattdCodeMonkey enabled auto-merge (squash) January 7, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse approved these changes

@mdefazio mdefazio mdefazio approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TattdCodeMonkey @elasticmachine @mdefazio @sphilipse @kibanamachine