Set relative date for host details link in onboarding flow #205622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykolaharmash
added
backport:skip
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
mykolaharmash
added
the
release_note:skip
gbamparop
reviewed
Jan 6, 2025
| @@ -183,6 +183,12 @@ export const AutoDetectPanel: FunctionComponent = () => { | |||
| href: assetDetailsLocator.getRedirectUrl({ | |||
| assetType: 'host', | |||
| assetId: integration.metadata?.hostname, | |||
| assetDetails: { | |||
There was a problem hiding this comment.
What is the current default time range?
There was a problem hiding this comment.
Also from -15 minutes to now, but it was not relative, once user navigated to the page it would get converted to an absolute timestamp and never change
💚 Build Succeeded
Metrics [docs]Async chunks
|
gbamparop
approved these changes
Jan 7, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 7, 2025
…05622) This change sets a relative date range to the host details link from the auto-detect onboarding flow. This prevents a situation when host details page would open saying there is no data and it would be stuck on a fixed date range unable to load data even if user refreshes the page. Somehow, even when onboarding flow can detect that the data was already ingested, the host details page might not see it for some reason. This requires a further investigation, but relative data range is a fix for the time being. (cherry picked from commit 212b192)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 7, 2025
…5622) (#205698) # Backport This will backport the following commits from `main` to `8.x`: - [Set relative date for host details link in onboarding flow (#205622)](#205622) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T10:22:07Z","message":"Set relative date for host details link in onboarding flow (#205622)\n\nThis change sets a relative date range to the host details link from the\r\nauto-detect onboarding flow. This prevents a situation when host details\r\npage would open saying there is no data and it would be stuck on a fixed\r\ndate range unable to load data even if user refreshes the page.\r\n\r\nSomehow, even when onboarding flow can detect that the data was already\r\ningested, the host details page might not see it for some reason. This\r\nrequires a further investigation, but relative data range is a fix for\r\nthe time being.","sha":"212b1926743ca5821992c2877d9c68f621e1875e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-logs"],"title":"Set relative date for host details link in onboarding flow","number":205622,"url":"https://github.com/elastic/kibana/pull/205622","mergeCommit":{"message":"Set relative date for host details link in onboarding flow (#205622)\n\nThis change sets a relative date range to the host details link from the\r\nauto-detect onboarding flow. This prevents a situation when host details\r\npage would open saying there is no data and it would be stuck on a fixed\r\ndate range unable to load data even if user refreshes the page.\r\n\r\nSomehow, even when onboarding flow can detect that the data was already\r\ningested, the host details page might not see it for some reason. This\r\nrequires a further investigation, but relative data range is a fix for\r\nthe time being.","sha":"212b1926743ca5821992c2877d9c68f621e1875e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205622","number":205622,"mergeCommit":{"message":"Set relative date for host details link in onboarding flow (#205622)\n\nThis change sets a relative date range to the host details link from the\r\nauto-detect onboarding flow. This prevents a situation when host details\r\npage would open saying there is no data and it would be stuck on a fixed\r\ndate range unable to load data even if user refreshes the page.\r\n\r\nSomehow, even when onboarding flow can detect that the data was already\r\ningested, the host details page might not see it for some reason. This\r\nrequires a further investigation, but relative data range is a fix for\r\nthe time being.","sha":"212b1926743ca5821992c2877d9c68f621e1875e"}}]}] BACKPORT--> Co-authored-by: Mykola Harmash <[email protected]>
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
…05622) This change sets a relative date range to the host details link from the auto-detect onboarding flow. This prevents a situation when host details page would open saying there is no data and it would be stuck on a fixed date range unable to load data even if user refreshes the page. Somehow, even when onboarding flow can detect that the data was already ingested, the host details page might not see it for some reason. This requires a further investigation, but relative data range is a fix for the time being.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…05622) This change sets a relative date range to the host details link from the auto-detect onboarding flow. This prevents a situation when host details page would open saying there is no data and it would be stuck on a fixed date range unable to load data even if user refreshes the page. Somehow, even when onboarding flow can detect that the data was already ingested, the host details page might not see it for some reason. This requires a further investigation, but relative data range is a fix for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets a relative date range to the host details link from the auto-detect onboarding flow. This prevents a situation when host details page would open saying there is no data and it would be stuck on a fixed date range unable to load data even if user refreshes the page.
Somehow, even when onboarding flow can detect that the data was already ingested, the host details page might not see it for some reason. This requires a further investigation, but relative data range is a fix for the time being.