[Fleet] Fix getBulkAssets behavior with missing dashboard #205619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
approved these changes
Jan 6, 2025
💚 Build Succeeded
Metrics [docs]
cc @nchaulet |
|
Starting backport for target branches: 8.x |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 6, 2025
) (#205640) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)](#205619) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-06T17:59:32Z","message":"[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)","sha":"d00a73c5e59425cdd07689e35ae5424097530fd4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet] Fix getBulkAssets behavior with missing dashboard","number":205619,"url":"https://github.com/elastic/kibana/pull/205619","mergeCommit":{"message":"[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)","sha":"d00a73c5e59425cdd07689e35ae5424097530fd4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205619","number":205619,"mergeCommit":{"message":"[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)","sha":"d00a73c5e59425cdd07689e35ae5424097530fd4"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
nchaulet
added
the
backport:prev-major
|
Starting backport for target branches: 8.16, 8.17, 8.x |
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 7, 2025
…5619) (#205658) # Backport This will backport the following commits from `main` to `8.16`: - [[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)](#205619) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-06T17:59:32Z","message":"[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)","sha":"d00a73c5e59425cdd07689e35ae5424097530fd4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","backport:prev-major","v8.18.0"],"title":"[Fleet] Fix getBulkAssets behavior with missing dashboard","number":205619,"url":"https://github.com/elastic/kibana/pull/205619","mergeCommit":{"message":"[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)","sha":"d00a73c5e59425cdd07689e35ae5424097530fd4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205619","number":205619,"mergeCommit":{"message":"[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)","sha":"d00a73c5e59425cdd07689e35ae5424097530fd4"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/205640","number":205640,"state":"MERGED","mergeCommit":{"sha":"d4f033b7367eb340d9af567995d06d4957ddc058","message":"[8.x] [Fleet] Fix getBulkAssets behavior with missing dashboard (#205619) (#205640)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Fleet] Fix getBulkAssets behavior with missing dashboard\n(#205619)](https://github.com/elastic/kibana/pull/205619)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Nicolas\nChaulet\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-01-06T17:59:32Z\",\"message\":\"[Fleet]\nFix getBulkAssets behavior with missing dashboard\n(#205619)\",\"sha\":\"d00a73c5e59425cdd07689e35ae5424097530fd4\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"Team:Fleet\",\"v9.0.0\",\"backport:prev-minor\"],\"title\":\"[Fleet]\nFix getBulkAssets behavior with missing\ndashboard\",\"number\":205619,\"url\":\"https://github.com/elastic/kibana/pull/205619\",\"mergeCommit\":{\"message\":\"[Fleet]\nFix getBulkAssets behavior with missing dashboard\n(#205619)\",\"sha\":\"d00a73c5e59425cdd07689e35ae5424097530fd4\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/205619\",\"number\":205619,\"mergeCommit\":{\"message\":\"[Fleet]\nFix getBulkAssets behavior with missing dashboard\n(#205619)\",\"sha\":\"d00a73c5e59425cdd07689e35ae5424097530fd4\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Nicolas Chaulet <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 7, 2025
…5619) (#205659) # Backport This will backport the following commits from `main` to `8.17`: - [[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)](#205619) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-06T17:59:32Z","message":"[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)","sha":"d00a73c5e59425cdd07689e35ae5424097530fd4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","backport:prev-major","v8.18.0"],"title":"[Fleet] Fix getBulkAssets behavior with missing dashboard","number":205619,"url":"https://github.com/elastic/kibana/pull/205619","mergeCommit":{"message":"[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)","sha":"d00a73c5e59425cdd07689e35ae5424097530fd4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205619","number":205619,"mergeCommit":{"message":"[Fleet] Fix getBulkAssets behavior with missing dashboard (#205619)","sha":"d00a73c5e59425cdd07689e35ae5424097530fd4"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/205640","number":205640,"state":"MERGED","mergeCommit":{"sha":"d4f033b7367eb340d9af567995d06d4957ddc058","message":"[8.x] [Fleet] Fix getBulkAssets behavior with missing dashboard (#205619) (#205640)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Fleet] Fix getBulkAssets behavior with missing dashboard\n(#205619)](https://github.com/elastic/kibana/pull/205619)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Nicolas\nChaulet\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-01-06T17:59:32Z\",\"message\":\"[Fleet]\nFix getBulkAssets behavior with missing dashboard\n(#205619)\",\"sha\":\"d00a73c5e59425cdd07689e35ae5424097530fd4\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"Team:Fleet\",\"v9.0.0\",\"backport:prev-minor\"],\"title\":\"[Fleet]\nFix getBulkAssets behavior with missing\ndashboard\",\"number\":205619,\"url\":\"https://github.com/elastic/kibana/pull/205619\",\"mergeCommit\":{\"message\":\"[Fleet]\nFix getBulkAssets behavior with missing dashboard\n(#205619)\",\"sha\":\"d00a73c5e59425cdd07689e35ae5424097530fd4\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/205619\",\"number\":205619,\"mergeCommit\":{\"message\":\"[Fleet]\nFix getBulkAssets behavior with missing dashboard\n(#205619)\",\"sha\":\"d00a73c5e59425cdd07689e35ae5424097530fd4\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Nicolas Chaulet <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
|
@nchaulet is there anything specific to do for 8.x here before FF? |
|
@consulthys Looks like it's already backported to 8.x #205640 |
|
@nchaulet I guess I was thrown off by the fact that the PRs for 8.16 and 8.17 stayed opened, but now that they are merged, it's all fine. Thanks again for the work and sorry for the noise |
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a breaking change introduce in #182180
Resolve #190980
Bulk get assets used to filter not found dashboard, this was used for stack monitoring to display a button to add elasticsearch integration.
That PR fix that.