Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[index management] Remove index unfreeze code #205617

Merged
merged 3 commits into from
Jan 8, 2025
Merged

[index management] Remove index unfreeze code #205617

merged 3 commits into from
Jan 8, 2025

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jan 6, 2025 •
edited
Loading

Summary

Remove code related to unfreezing indices since the functionality is being removed from v9 due to elastic/elasticsearch#119227

@mattkime
Copy link
Contributor Author

mattkime commented Jan 6, 2025

/ci

@mattkime
Copy link
Contributor Author

mattkime commented Jan 6, 2025

/ci

@mattkime mattkime changed the title remove unfreeze code [index management] Remove index unfreeze code Jan 8, 2025
@mattkime mattkime self-assigned this Jan 8, 2025
@mattkime mattkime added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Index Management Index and index templates UI labels Jan 8, 2025
@mattkime mattkime marked this pull request as ready for review January 8, 2025 01:45
@mattkime mattkime requested a review from a team as a code owner January 8, 2025 01:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts / discover/group1 discover test nested query should support querying on nested fields

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexManagement 679 678 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 700.9KB 699.5KB -1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexManagement 44.3KB 44.1KB -188.0B

History

cc @mattkime

sabarasaba
sabarasaba approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, verified locally 🚀

@mattkime mattkime merged commit 2b5b442 into elastic:main Jan 8, 2025
8 checks passed
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jan 8, 2025
@mattkime @crespocarlos
[index management] Remove index unfreeze code (elastic#205617)
9ad96e8 
## Summary

Remove code related to unfreezing indices since the functionality is
being removed from v9 due to
elastic/elasticsearch#119227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees

@mattkime mattkime

Labels
backport:skip This commit does not require backporting Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattkime @elasticmachine @sabarasaba @kibanamachine