Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streams] Make root stream selectively immutable #205609

Merged

Conversation

Kerry350
Copy link
Contributor

@Kerry350 Kerry350 commented Jan 6, 2025

Summary

This closes https://github.com/elastic/streams-program/issues/54.

The root stream is selectively immutable (processing and fields changes are not allowed).

UI

For the UI I've entirely disabled the actions column for the root stream in the schema editor. All of the information (bar the preview table for changes) available in the flyout for a field is already available in the table, so this seems easiest for now to avoid multiple logic forks wrapping buttons etc.

E.g. flyout vs table

Screenshot 2025-01-02 at 13 41 55

@Kerry350 Kerry350 added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.18.0 Feature:Streams This is the label for the Streams Project labels Jan 6, 2025
@Kerry350 Kerry350 self-assigned this Jan 6, 2025
@Kerry350 Kerry350 requested review from a team as code owners January 6, 2025 14:16
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 7, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #103 / serverless observability UI Dataset Quality Dataset quality summary shows poor, degraded and good count as 0 and all dataset as healthy
  • [job] [logs] FTR Configs #103 / serverless observability UI Dataset Quality Dataset quality summary shows poor, degraded and good count as 0 and all dataset as healthy
  • [job] [logs] FTR Configs #103 / serverless observability UI Dataset Quality Dataset quality summary shows poor, degraded and good count as 0 and all dataset as healthy

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

cc @Kerry350

@Kerry350 Kerry350 merged commit 4ba5879 into elastic:main Jan 8, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12670671317

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Streams] Dashboard linking (#204309)

Manual backport

To create the backport manually run:

node scripts/backport --pr 205609

Questions ?

Please refer to the Backport tool documentation

crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jan 8, 2025
## Summary

This closes elastic/streams-program#54.

The root stream is selectively immutable (processing and fields changes
are not allowed).

## UI

For the UI I've entirely disabled the actions column for the root stream
in the schema editor. All of the information (bar the preview table for
changes) available in the flyout for a field is already available in the
table, so this seems easiest for now to avoid multiple logic forks
wrapping buttons etc.

E.g. flyout vs table

![Screenshot 2025-01-02 at 13 41
55](https://github.com/user-attachments/assets/867fd67c-4acc-4457-ad5f-0eb5e9d9ce3f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants