-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Streams] Make root stream selectively immutable #205609
Merged
Kerry350
merged 4 commits into
elastic:main
from
Kerry350:54-selectively-immutable-root-stream
Jan 8, 2025
Merged
[Streams] Make root stream selectively immutable #205609
Kerry350
merged 4 commits into
elastic:main
from
Kerry350:54-selectively-immutable-root-stream
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerry350
added
release_note:skip
Skip the PR/issue when compiling release notes
v9.0.0
backport:version
Backport to applied version labels
v8.18.0
Feature:Streams
This is the label for the Streams Project
labels
Jan 6, 2025
dgieselaar
reviewed
Jan 7, 2025
x-pack/solutions/observability/plugins/streams/server/routes/streams/edit.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/observability/plugins/streams/server/routes/streams/edit.ts
Outdated
Show resolved
Hide resolved
💔 Build Failed
Failed CI StepsTest Failures
The CI Stats report is too large to be displayed here, check out the CI build annotation for this information. History
cc @Kerry350 |
dgieselaar
approved these changes
Jan 7, 2025
simianhacker
approved these changes
Jan 7, 2025
…table-root-stream
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jan 8, 2025
## Summary This closes elastic/streams-program#54. The root stream is selectively immutable (processing and fields changes are not allowed). ## UI For the UI I've entirely disabled the actions column for the root stream in the schema editor. All of the information (bar the preview table for changes) available in the flyout for a field is already available in the table, so this seems easiest for now to avoid multiple logic forks wrapping buttons etc. E.g. flyout vs table ![Screenshot 2025-01-02 at 13 41 55](https://github.com/user-attachments/assets/867fd67c-4acc-4457-ad5f-0eb5e9d9ce3f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
Feature:Streams
This is the label for the Streams Project
release_note:skip
Skip the PR/issue when compiling release notes
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This closes https://github.com/elastic/streams-program/issues/54.
The root stream is selectively immutable (processing and fields changes are not allowed).
UI
For the UI I've entirely disabled the actions column for the root stream in the schema editor. All of the information (bar the preview table for changes) available in the flyout for a field is already available in the table, so this seems easiest for now to avoid multiple logic forks wrapping buttons etc.
E.g. flyout vs table