fix: [Security:Cases] Sync alert status with case status toggle button under case settings on create case page is incorrectly announced #205604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
added
release_note:skip
|
/ci |
…n under case settings on create case page is incorrectly announced Closes: elastic#205544
💚 Build Succeeded
Metrics [docs]Page load bundle
History
|
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
sabarasaba
approved these changes
Jan 8, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2025
…n under case settings on create case page is incorrectly announced (elastic#205604) Closes: elastic#205544 ## Description When user tabs over sync alert status with case status toggle button under case settings on create case page, screenreader announces On, On switch without giving any context. ## Preconditions Security solution -> on cases page -> create case ## Changes made: 1. added context for **EuiSwitch** by passing `aria-labelledby` attribute ## Screen  (cherry picked from commit efe44b2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 8, 2025
… button under case settings on create case page is incorrectly announced (#205604) (#205938) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Security:Cases] Sync alert status with case status toggle button under case settings on create case page is incorrectly announced (#205604)](#205604) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T16:57:41Z","message":"fix: [Security:Cases] Sync alert status with case status toggle button under case settings on create case page is incorrectly announced (#205604)\n\nCloses: #205544\r\n\r\n## Description\r\nWhen user tabs over sync alert status with case status toggle button\r\nunder case settings on create case page, screenreader announces On, On\r\nswitch without giving any context.\r\n\r\n## Preconditions\r\nSecurity solution -> on cases page -> create case\r\n\r\n## Changes made: \r\n1. added context for **EuiSwitch** by passing `aria-labelledby`\r\nattribute\r\n\r\n## Screen\r\n\r\n\r\n","sha":"efe44b2f2d97fd35f152fd93c5a2ffdcf57dbe2e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","backport:prev-minor"],"title":"fix: [Security:Cases] Sync alert status with case status toggle button under case settings on create case page is incorrectly announced","number":205604,"url":"https://github.com/elastic/kibana/pull/205604","mergeCommit":{"message":"fix: [Security:Cases] Sync alert status with case status toggle button under case settings on create case page is incorrectly announced (#205604)\n\nCloses: #205544\r\n\r\n## Description\r\nWhen user tabs over sync alert status with case status toggle button\r\nunder case settings on create case page, screenreader announces On, On\r\nswitch without giving any context.\r\n\r\n## Preconditions\r\nSecurity solution -> on cases page -> create case\r\n\r\n## Changes made: \r\n1. added context for **EuiSwitch** by passing `aria-labelledby`\r\nattribute\r\n\r\n## Screen\r\n\r\n\r\n","sha":"efe44b2f2d97fd35f152fd93c5a2ffdcf57dbe2e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205604","number":205604,"mergeCommit":{"message":"fix: [Security:Cases] Sync alert status with case status toggle button under case settings on create case page is incorrectly announced (#205604)\n\nCloses: #205544\r\n\r\n## Description\r\nWhen user tabs over sync alert status with case status toggle button\r\nunder case settings on create case page, screenreader announces On, On\r\nswitch without giving any context.\r\n\r\n## Preconditions\r\nSecurity solution -> on cases page -> create case\r\n\r\n## Changes made: \r\n1. added context for **EuiSwitch** by passing `aria-labelledby`\r\nattribute\r\n\r\n## Screen\r\n\r\n\r\n","sha":"efe44b2f2d97fd35f152fd93c5a2ffdcf57dbe2e"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #205544
Description
When user tabs over sync alert status with case status toggle button under case settings on create case page, screenreader announces On, On switch without giving any context.
Preconditions
Security solution -> on cases page -> create case
Changes made:
aria-labelledbyattributeScreen