Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Solution] Display unavailable ML jobs (#205483) #205601

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

**Resolves: elastic#202700

## Summary
This PR resolves an issue where an ML job referenced by a rule does not
appear in the Rule Details, Upgrade flyout, or Rule Editing pages if the
job is missing or not yet created.

For example, if you had an ML rule with a single selected job and this
job was not available, you would see a blank space instead of job name.

## Screenshots
**Rule Details: Before**
<img width="578" alt="Scherm­afbeelding 2025-01-03 om 13 20 32"
src="https://github.com/user-attachments/assets/e8bc073f-0420-4888-8dd9-b4dc70fd0682"
/>

**Rule Details: After**
<img width="578" alt="Scherm­afbeelding 2025-01-03 om 13 20 05"
src="https://github.com/user-attachments/assets/bd4d0f91-8adf-45c5-8d31-b42ac483027b"
/>

**Rule Edit: Before**
<img width="427" alt="Scherm­afbeelding 2025-01-03 om 13 21 21"
src="https://github.com/user-attachments/assets/bffcb871-8cfc-4f50-8d19-c14b122c0be4"
/>

**Rule Edit: After**
<img width="427" alt="Scherm­afbeelding 2025-01-03 om 13 21 09"
src="https://github.com/user-attachments/assets/be8f60b9-17a6-48d2-978c-cfa63c426a08"
/>

**Upgrade flyout: Before**
<img width="1066" alt="Scherm­afbeelding 2025-01-03 om 13 22 30"
src="https://github.com/user-attachments/assets/553ff837-95cf-4670-91f1-dffb169ec505"
/>

**Upgrade flyout: After**
<img width="1066" alt="Scherm­afbeelding 2025-01-03 om 13 21 55"
src="https://github.com/user-attachments/assets/150cfb82-bc69-4aeb-a20a-03f54c7edc70"
/>

## Testing
You can test by removing an ML job referenced by a rule in
`http://localhost:<port>/kbn/app/ml/jobs`.

(cherry picked from commit e04b200)
@kibanamachine kibanamachine merged commit b44cff1 into elastic:8.x Jan 6, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 19.1MB 19.2MB +4.3KB

cc @nikitaindik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants