Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Security:Rules:SharedExceptionList] The toggle button for linking a rule on add rule exception panel is missing discernible text #205600

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: [Security:Rules:SharedExceptionList] The toggle button for linking a rule on add rule exception panel is missing discernible text #205600

wants to merge 2 commits into from
+24 −1

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jan 6, 2025

Closes: #204667

Summary

The toggle button for linking to a rule on Add rule exception panel is missing discernible text
Preconditions
Security -> Rules->Shared exceptions ->Add rule exception panel is open

Changes made:

  1. Added 'label' attribute for EuiSwitch

Screen

image

@alexwizp
fix: [Security:Rules:SharedExceptionList] The toggle button for linki…
a6ed932 
…ng a rule on add rule exception panel is missing discernible text

Closes: elastic#204667
@alexwizp alexwizp added v9.0.0 Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jan 6, 2025
@alexwizp
Copy link
Contributor Author

alexwizp commented Jan 6, 2025

/ci

@alexwizp alexwizp added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Jan 6, 2025
@alexwizp alexwizp marked this pull request as ready for review January 6, 2025 14:23
@alexwizp alexwizp requested a review from a team as a code owner January 6, 2025 14:23
@alexwizp alexwizp requested a review from dhurley14 January 6, 2025 14:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 8, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley14 dhurley14 Awaiting requested review from dhurley14 dhurley14 is a code owner automatically assigned from elastic/security-detection-engine

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v9.0.0
Projects
None yet
Milestone
No milestone
2 participants
@alexwizp @elasticmachine