Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] fix platform selector css #205598

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Jan 6, 2025

Summary

Fix error that came when clicking on Add agent in Fleet

Before:
image

After:
image

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 6, 2025
@juliaElastic juliaElastic self-assigned this Jan 6, 2025
@juliaElastic juliaElastic requested a review from a team as a code owner January 6, 2025 11:54
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 6, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@jillguyonnet jillguyonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! 🚀

@juliaElastic juliaElastic enabled auto-merge (squash) January 6, 2025 12:53
@juliaElastic juliaElastic merged commit 8113ddf into elastic:main Jan 6, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12636142680

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +1.0B

History

cc @juliaElastic

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 6, 2025
## Summary

Fix error that came when clicking on Add agent in Fleet

Before:

![image](https://github.com/user-attachments/assets/0fb8e8ec-565e-41a0-bdbb-857585bcdad4)

After:
<img width="1690" alt="image"
src="https://github.com/user-attachments/assets/70df4792-aab9-4230-8f7b-55eeb0ef57ab"
/>

(cherry picked from commit 8113ddf)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 6, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] fix platform selector css
(#205598)](#205598)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Bardi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-06T16:19:42Z","message":"[Fleet]
fix platform selector css (#205598)\n\n## Summary\r\n\r\nFix error that
came when clicking on Add agent in
Fleet\r\n\r\nBefore:\r\n\r\n![image](https://github.com/user-attachments/assets/0fb8e8ec-565e-41a0-bdbb-857585bcdad4)\r\n\r\n\r\nAfter:\r\n<img
width=\"1690\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/70df4792-aab9-4230-8f7b-55eeb0ef57ab\"\r\n/>","sha":"8113ddfb30458ed36a902e11f127432c433db2dc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet]
fix platform selector
css","number":205598,"url":"https://github.com/elastic/kibana/pull/205598","mergeCommit":{"message":"[Fleet]
fix platform selector css (#205598)\n\n## Summary\r\n\r\nFix error that
came when clicking on Add agent in
Fleet\r\n\r\nBefore:\r\n\r\n![image](https://github.com/user-attachments/assets/0fb8e8ec-565e-41a0-bdbb-857585bcdad4)\r\n\r\n\r\nAfter:\r\n<img
width=\"1690\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/70df4792-aab9-4230-8f7b-55eeb0ef57ab\"\r\n/>","sha":"8113ddfb30458ed36a902e11f127432c433db2dc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205598","number":205598,"mergeCommit":{"message":"[Fleet]
fix platform selector css (#205598)\n\n## Summary\r\n\r\nFix error that
came when clicking on Add agent in
Fleet\r\n\r\nBefore:\r\n\r\n![image](https://github.com/user-attachments/assets/0fb8e8ec-565e-41a0-bdbb-857585bcdad4)\r\n\r\n\r\nAfter:\r\n<img
width=\"1690\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/70df4792-aab9-4230-8f7b-55eeb0ef57ab\"\r\n/>","sha":"8113ddfb30458ed36a902e11f127432c433db2dc"}}]}]
BACKPORT-->

Co-authored-by: Julia Bardi <[email protected]>
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants