Feature/ai assistant citations #205586
Draft
Feature/ai assistant citations #205586
+727
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
…ana into feature/ai-assistant-citations
KDKHD
force-pushed
the
feature/ai-assistant-citations
branch
from
e0e6b14 to
7785e37
Compare
…ana into feature/ai-assistant-citations
KDKHD
commented
Jan 8, 2025
Comment on lines
-22
to
-30
| jest.mock('@kbn/zod', () => ({ | ||
| z: { | ||
| string: jest.fn().mockReturnValue({ describe: (str: string) => str }), | ||
| number: jest.fn().mockReturnValue({ describe: (str: string) => str }), | ||
| boolean: jest.fn().mockReturnValue({ describe: (str: string) => str }), | ||
| object: jest.fn().mockReturnValue({ describe: (str: string) => str }), | ||
| any: jest.fn().mockReturnValue({ describe: (str: string) => str }), | ||
| }, | ||
| })); |
There was a problem hiding this comment.
This mock started breaking tests because it did not mock everything in zod. The tests also passed without the mock so I removed this.
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds citations to the security AI assistant. Citations are produced when tools are used and they are displayed in the LLM response as numbered superscript elements. A label appears when the user hovers over the numbered elements and clicking on the label opens a new tab that displays the cited data.
Tools that are cited:
Changes:
citationElementstring e.g.!{citation[global_threat_report_entry](/app/management/kibana/securityAiAssistantManagement?tab=knowledge_base&entry_search_term=5e981c00-26bb-497b-a3ee-feb8bfe19bfc)}citationElements from the LLM response and renders them in the AI assistant.Considerations:
Eventually direct prompting in combination with
citationElementmeant that the LLM had enough contextual information to produce good citations and no additional LLM calls were required.Jan-07-2025.14-33-21.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.