Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs AI Assistant] Rename chat to chatCompletion and complete to runTools to align with OpenAI terminology #205585

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[Obs AI Assistant] Rename chat to chatCompletion and complete to runTools to align with OpenAI terminology #205585

wants to merge 8 commits into from
+246 −239

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Jan 6, 2025 •
edited
Loading

Closes #205583

This PR renames chat to chatCompletion and complete to runTools

API renaming

  • POST /internal/observability_ai_assistant/chat to POST /internal/observability_ai_assistant/chat/completion
  • POST /internal/observability_ai_assistant/chat/complete to /internal/observability_ai_assistant/chat/completion/run_tools
  • POST /api/observability_ai_assistant/chat/complete to /api/observability_ai_assistant/chat/run_tools

@sorenlouv sorenlouv changed the title Rename chat to chatCompletion and complete to `recursiveChatCom… Rename chat to chatCompletion and complete to recursiveChatCompletion Jan 6, 2025
@sorenlouv sorenlouv changed the title Rename chat to chatCompletion and complete to recursiveChatCompletion [Obs AI Assistant] Rename chat to chatCompletion and complete to recursiveChatCompletion Jan 6, 2025
@sorenlouv sorenlouv changed the title [Obs AI Assistant] Rename chat to chatCompletion and complete to recursiveChatCompletion [Obs AI Assistant] Rename chat to chatCompletion and complete to runTools to align with OpenAI terminology Jan 6, 2025
@sorenlouv sorenlouv marked this pull request as ready for review January 6, 2025 14:51
@sorenlouv sorenlouv requested review from a team as code owners January 6, 2025 14:51
@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 6, 2025
@elasticmachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [69cb966]

@sorenlouv sorenlouv marked this pull request as draft January 8, 2025 10:29
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] Rename chat completion methods to align with LLM vendor terminology
2 participants
@sorenlouv @elasticmachine