[Cloud Security] Adds KQL filter to graph component #205570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
- Filters based on KQL filter - Added e2e tests and UT - Shows toast message on syntax error - Adapts the kql filter when open timeline for investigation
kfirpeled
force-pushed
the
cspm/graph-add-kql-filter
branch
from
4ec15fe to
571da79
Compare
kfirpeled
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
kfirpeled
changed the title
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7669[✅] x-pack/test/cloud_security_posture_functional/config.ts: 25/25 tests passed. |
opauloh
reviewed
Jan 8, 2025
| }); | ||
|
|
||
| it('calls refresh on submit button click', () => { | ||
| const mockRefresh = action('refresh'); |
There was a problem hiding this comment.
For better maintainability, we should define a central place where we store Storybook actions in a constant, otherwise, as it grows it can become tricky to understand where actions such as refresh and notifications:addError are coming from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes the following changes to the graph investigation component:
Screen.Recording.2025-01-08.at.14.43.22.mov
How to test:
To test this PR using storybook (alternatively access to storybooks attached to this build)
To test e2e:
kibana.dev.yml:node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/logs_gcp_audit \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601 node scripts/es_archiver load x-pack/test/cloud_security_posture_functional/es_archives/security_alerts \ --es-url http://elastic:changeme@localhost:9200 \ --kibana-url http://elastic:changeme@localhost:5601To run FTR tests:
E2E tests 📹
Screen.Recording.2025-01-08.at.14.22.22.mov
Checklist