Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-security (#202748) #205569

Merged
merged 1 commit into from
Jan 6, 2025
Merged

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-security (#202748) #205569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
22 changes: 11 additions & 11 deletions .buildkite/scripts/pipelines/pull_request/pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const getPipeline = (filename: string, removeSteps = true) => {

pipeline.push(getPipeline('.buildkite/pipelines/pull_request/base.yml', false));

if (await doAnyChangesMatch([/^packages\/kbn-handlebars/])) {
if (await doAnyChangesMatch([/^src\/platform\/packages\/private\/kbn-handlebars/])) {
pipeline.push(getPipeline('.buildkite/pipelines/pull_request/kbn_handlebars.yml'));
}

Expand Down Expand Up @@ -236,7 +236,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
if (
(await doAnyChangesMatch([
/^packages\/kbn-securitysolution-.*/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution/,
/^x-pack\/test\/defend_workflows_cypress/,
/^x-pack\/test\/security_solution_cypress/,
/^fleet_packages\.json/,
Expand All @@ -256,9 +256,9 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^x-pack\/platform\/plugins\/shared\/data_views\/common/,
/^x-pack\/solutions\/security\/plugins\/lists/,
/^x-pack\/platform\/plugins\/shared\/rule_registry\/common/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/plugins\/security_solution_ess/,
/^x-pack\/solutions\/security\/plugins\/security_solution_serverless/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution_ess/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution_serverless/,
/^x-pack\/platform\/plugins\/shared\/task_manager/,
/^x-pack\/solutions\/security\/plugins\/timelines/,
/^x-pack\/platform\/plugins\/shared\/triggers_actions_ui\/public\/application\/sections\/action_connector_form/,
Expand Down Expand Up @@ -306,7 +306,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^src\/platform\/packages\/shared\/kbn-resizable-layout/,
/^src\/platform\/packages\/shared\/kbn-rison/,
/^src\/platform\/packages\/shared\/kbn-rule-data-utils/,
/^packages\/kbn-safer-lodash-set/,
/^src\/platform\/packages\/shared\/kbn-safer-lodash-set/,
/^src\/platform\/packages\/shared\/kbn-search-types/,
/^packages\/kbn-securitysolution-.*/,
/^src\/platform\/packages\/shared\/kbn-securitysolution-ecs/,
Expand Down Expand Up @@ -341,9 +341,9 @@ const getPipeline = (filename: string, removeSteps = true) => {
/^x-pack\/solutions\/security\/plugins\/elastic_assistant/,
/^x-pack\/solutions\/security\/plugins\/lists/,
/^x-pack\/platform\/plugins\/shared\/rule_registry\/common/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/plugins\/security_solution_ess/,
/^x-pack\/solutions\/security\/plugins\/security_solution_serverless/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution_ess/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution_serverless/,
/^x-pack\/platform\/plugins\/shared\/task_manager/,
/^x-pack\/solutions\/security\/plugins\/threat_intelligence/,
/^x-pack\/solutions\/security\/plugins\/timelines/,
Expand All @@ -363,7 +363,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
((await doAnyChangesMatch([
/^x-pack\/platform\/plugins\/shared\/osquery/,
/^x-pack\/test\/osquery_cypress/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution/,
])) ||
GITHUB_PR_LABELS.includes('ci:all-cypress-suites')) &&
!GITHUB_PR_LABELS.includes('ci:skip-cypress-osquery')
Expand All @@ -377,7 +377,7 @@ const getPipeline = (filename: string, removeSteps = true) => {
(await doAnyChangesMatch([
/^x-pack\/packages\/kbn-cloud-security-posture/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/cloud_security_posture/,
/^x-pack\/solutions\/security\/plugins\/security_solution/,
/^x-pack\/solutions\/security\/platform\/plugins\/shared\/security_solution/,
/^x-pack\/test\/security_solution_cypress/,
])) ||
GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/scripts/steps/test/kbn_handlebars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ set -euo pipefail
source .buildkite/scripts/common/util.sh

echo '--- Checking for @kbn/handlebars upstream updates'
packages/kbn-handlebars/scripts/check_for_upstream_updates.sh
src/platform/packages/private/kbn-handlebars/scripts/check_for_upstream_updates.sh
34 changes: 17 additions & 17 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const ELV2_LICENSE_HEADER = `
const SAFER_LODASH_SET_HEADER = `
/*
* Elasticsearch B.V licenses this file to you under the MIT License.
* See \`packages/kbn-safer-lodash-set/LICENSE\` for more information.
* See \`src/platform/packages/shared/kbn-safer-lodash-set/LICENSE\` for more information.
*/
`;

Expand All @@ -93,7 +93,7 @@ const SAFER_LODASH_SET_LODASH_HEADER = `
* This file is forked from the lodash project (https://lodash.com/),
* and may include modifications made by Elasticsearch B.V.
* Elasticsearch B.V. licenses this file to you under the MIT License.
* See \`packages/kbn-safer-lodash-set/LICENSE\` for more information.
* See \`src/platform/packages/shared/kbn-safer-lodash-set/LICENSE\` for more information.
*/
`;

Expand All @@ -102,14 +102,14 @@ const SAFER_LODASH_SET_DEFINITELYTYPED_HEADER = `
* This file is forked from the DefinitelyTyped project (https://github.com/DefinitelyTyped/DefinitelyTyped),
* and may include modifications made by Elasticsearch B.V.
* Elasticsearch B.V. licenses this file to you under the MIT License.
* See \`packages/kbn-safer-lodash-set/LICENSE\` for more information.
* See \`src/platform/packages/shared/kbn-safer-lodash-set/LICENSE\` for more information.
*/
`;

const KBN_HANDLEBARS_HEADER = `
/*
* Elasticsearch B.V licenses this file to you under the MIT License.
* See \`packages/kbn-handlebars/LICENSE\` for more information.
* See \`src/platform/packages/private/kbn-handlebars/LICENSE\` for more information.
*/
`;

Expand All @@ -118,7 +118,7 @@ const KBN_HANDLEBARS_HANDLEBARS_HEADER = `
* This file is forked from the handlebars project (https://github.com/handlebars-lang/handlebars.js),
* and may include modifications made by Elasticsearch B.V.
* Elasticsearch B.V. licenses this file to you under the MIT License.
* See \`packages/kbn-handlebars/LICENSE\` for more information.
* See \`src/platform/packages/private/kbn-handlebars/LICENSE\` for more information.
*/
`;

Expand Down Expand Up @@ -441,7 +441,7 @@ module.exports = {
* safer-lodash-set package requires special license headers
*/
{
files: ['packages/kbn-safer-lodash-set/**/*.{js,mjs,ts,tsx}'],
files: ['src/platform/packages/shared/kbn-safer-lodash-set/**/*.{js,mjs,ts,tsx}'],
rules: {
'@kbn/eslint/require-license-header': [
'error',
Expand Down Expand Up @@ -471,7 +471,7 @@ module.exports = {
},

{
files: ['packages/kbn-safer-lodash-set/test/*.{js,mjs,ts,tsx}'],
files: ['src/platform/packages/shared/kbn-safer-lodash-set/test/*.{js,mjs,ts,tsx}'],
rules: {
'@kbn/eslint/require-license-header': [
'error',
Expand Down Expand Up @@ -500,7 +500,7 @@ module.exports = {
},
},
{
files: ['packages/kbn-safer-lodash-set/**/*.d.ts'],
files: ['src/platform/packages/shared/kbn-safer-lodash-set/**/*.d.ts'],
rules: {
'@kbn/eslint/require-license-header': [
'error',
Expand Down Expand Up @@ -533,7 +533,7 @@ module.exports = {
* @kbn/handlebars package requires special license headers
*/
{
files: ['packages/kbn-handlebars/**/*.{js,mjs,ts,tsx}'],
files: ['src/platform/packages/private/kbn-handlebars/**/*.{js,mjs,ts,tsx}'],
rules: {
'@kbn/eslint/require-license-header': [
'error',
Expand Down Expand Up @@ -562,7 +562,7 @@ module.exports = {
},
},
{
files: ['packages/kbn-handlebars/src/spec/**/*.{js,mjs,ts,tsx}'],
files: ['src/platform/packages/private/kbn-handlebars/src/spec/**/*.{js,mjs,ts,tsx}'],
rules: {
'@kbn/eslint/require-license-header': [
'error',
Expand Down Expand Up @@ -778,7 +778,7 @@ module.exports = {
* Harden specific rules
*/
{
files: ['test/harden/*.js', 'packages/kbn-safer-lodash-set/test/*.js'],
files: ['test/harden/*.js', 'src/platform/packages/shared/kbn-safer-lodash-set/test/*.js'],
rules: {
'mocha/handle-done-callback': 'off',
},
Expand Down Expand Up @@ -1840,24 +1840,24 @@ module.exports = {
*/
{
files: [
'src/plugins/interactive_setup/**/*.{js,mjs,ts,tsx}',
'src/platform/plugins/private/interactive_setup/**/*.{js,mjs,ts,tsx}',
'test/interactive_setup_api_integration/**/*.{js,mjs,ts,tsx}',
'test/interactive_setup_functional/**/*.{js,mjs,ts,tsx}',

'packages/kbn-mock-idp-plugin/**/*.{js,mjs,ts,tsx}',
'packages/kbn-mock-idp-utils/**/*.{js,mjs,ts,tsx}',
'packages/kbn-security-hardening/**/*.{js,mjs,ts,tsx}',
'packages/kbn-user-profile-components/**/*.{js,mjs,ts,tsx}',
'src/platform/packages/shared/kbn-security-hardening/**/*.{js,mjs,ts,tsx}',
'src/platform/packages/shared/kbn-user-profile-components/**/*.{js,mjs,ts,tsx}',

'x-pack/plugins/encrypted_saved_objects/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/plugins/shared/encrypted_saved_objects/**/*.{js,mjs,ts,tsx}',
'x-pack/test/encrypted_saved_objects_api_integration/**/*.{js,mjs,ts,tsx}',

'x-pack/plugins/security/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/plugins/shared/security/**/*.{js,mjs,ts,tsx}',
'x-pack/packages/security/**/*.{js,mjs,ts,tsx}',
'x-pack/test/security_api_integration/**/*.{js,mjs,ts,tsx}',
'x-pack/test/security_functional/**/*.{js,mjs,ts,tsx}',

'x-pack/plugins/spaces/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/plugins/shared/spaces/**/*.{js,mjs,ts,tsx}',
'x-pack/test/spaces_api_integration/**/*.{js,mjs,ts,tsx}',
],
rules: {
Expand Down
39 changes: 19 additions & 20 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ packages/core/user-settings/core-user-settings-server @elastic/kibana-security
packages/core/user-settings/core-user-settings-server-internal @elastic/kibana-security
packages/core/user-settings/core-user-settings-server-mocks @elastic/kibana-security
x-pack/platform/plugins/private/cross_cluster_replication @elastic/kibana-management
packages/kbn-crypto @elastic/kibana-security
src/platform/packages/shared/kbn-crypto @elastic/kibana-security
src/platform/packages/shared/kbn-crypto-browser @elastic/kibana-core
x-pack/platform/plugins/private/custom_branding @elastic/appex-sharedux
src/platform/packages/shared/kbn-custom-icons @elastic/obs-ux-logs-team
Expand Down Expand Up @@ -411,7 +411,7 @@ x-pack/platform/plugins/shared/embeddable_enhanced @elastic/kibana-presentation
examples/embeddable_examples @elastic/kibana-presentation
src/platform/plugins/shared/embeddable @elastic/kibana-presentation
x-pack/examples/embedded_lens_example @elastic/kibana-visualizations
x-pack/plugins/encrypted_saved_objects @elastic/kibana-security
x-pack/platform/plugins/shared/encrypted_saved_objects @elastic/kibana-security
x-pack/solutions/search/plugins/enterprise_search @elastic/search-kibana
x-pack/solutions/observability/plugins/observability_solution/entities_data_access @elastic/obs-entities
x-pack/platform/packages/shared/kbn-entities-schema @elastic/obs-entities
Expand Down Expand Up @@ -512,7 +512,7 @@ src/platform/packages/shared/kbn-grouping @elastic/response-ops
packages/kbn-guided-onboarding @elastic/appex-sharedux
examples/guided_onboarding_example @elastic/appex-sharedux
src/platform/plugins/shared/guided_onboarding @elastic/appex-sharedux
packages/kbn-handlebars @elastic/kibana-security
src/platform/packages/private/kbn-handlebars @elastic/kibana-security
src/platform/packages/private/kbn-hapi-mocks @elastic/kibana-core
test/plugin_functional/plugins/hardening @elastic/kibana-security
src/platform/packages/private/kbn-health-gateway-server @elastic/kibana-core
Expand Down Expand Up @@ -543,7 +543,7 @@ x-pack/platform/plugins/shared/ingest_pipelines @elastic/kibana-management
src/platform/plugins/private/input_control_vis @elastic/kibana-presentation
src/platform/plugins/shared/inspector @elastic/kibana-presentation
x-pack/platform/plugins/shared/integration_assistant @elastic/security-scalability
src/plugins/interactive_setup @elastic/kibana-security
src/platform/plugins/private/interactive_setup @elastic/kibana-security
test/interactive_setup_api_integration/plugins/test_endpoints @elastic/kibana-security
packages/kbn-interpreter @elastic/kibana-visualizations
x-pack/solutions/observability/plugins/inventory/e2e @elastic/obs-ux-infra_services-team
Expand Down Expand Up @@ -762,7 +762,7 @@ src/platform/packages/shared/kbn-rrule @elastic/response-ops
src/platform/packages/shared/kbn-rule-data-utils @elastic/security-detections-response @elastic/response-ops @elastic/obs-ux-management-team
x-pack/platform/plugins/shared/rule_registry @elastic/response-ops @elastic/obs-ux-management-team
x-pack/platform/plugins/private/runtime_fields @elastic/kibana-management
packages/kbn-safer-lodash-set @elastic/kibana-security
src/platform/packages/shared/kbn-safer-lodash-set @elastic/kibana-security
x-pack/test/security_api_integration/plugins/saml_provider @elastic/kibana-security
x-pack/test/plugin_api_integration/plugins/sample_task_plugin @elastic/response-ops
x-pack/test/task_manager_claimer_update_by_query/plugins/sample_task_plugin_mget @elastic/response-ops
Expand Down Expand Up @@ -807,16 +807,16 @@ x-pack/solutions/search/packages/search/shared_ui @elastic/search-kibana
src/platform/packages/shared/kbn-search-types @elastic/kibana-data-discovery
x-pack/platform/plugins/shared/searchprofiler @elastic/kibana-management
x-pack/test/security_api_integration/packages/helpers @elastic/kibana-security
x-pack/packages/security/api_key_management @elastic/kibana-security
x-pack/packages/security/authorization_core @elastic/kibana-security
x-pack/packages/security/authorization_core_common @elastic/kibana-security
x-pack/packages/security/form_components @elastic/kibana-security
packages/kbn-security-hardening @elastic/kibana-security
x-pack/plugins/security @elastic/kibana-security
x-pack/packages/security/plugin_types_common @elastic/kibana-security
x-pack/packages/security/plugin_types_public @elastic/kibana-security
x-pack/packages/security/plugin_types_server @elastic/kibana-security
x-pack/packages/security/role_management_model @elastic/kibana-security
x-pack/platform/packages/shared/security/api_key_management @elastic/kibana-security
x-pack/platform/packages/private/security/authorization_core @elastic/kibana-security
x-pack/platform/packages/private/security/authorization_core_common @elastic/kibana-security
x-pack/platform/packages/shared/security/form_components @elastic/kibana-security
src/platform/packages/shared/kbn-security-hardening @elastic/kibana-security
x-pack/platform/plugins/shared/security @elastic/kibana-security
x-pack/platform/packages/shared/security/plugin_types_common @elastic/kibana-security
x-pack/platform/packages/shared/security/plugin_types_public @elastic/kibana-security
x-pack/platform/packages/shared/security/plugin_types_server @elastic/kibana-security
x-pack/platform/packages/private/security/role_management_model @elastic/kibana-security
x-pack/solutions/security/packages/distribution_bar @elastic/kibana-cloud-security-posture
x-pack/solutions/security/plugins/security_solution_ess @elastic/security-solution
x-pack/solutions/security/packages/features @elastic/security-threat-hunting-explore
Expand All @@ -828,7 +828,7 @@ x-pack/solutions/security/packages/side_nav @elastic/security-threat-hunting-exp
x-pack/solutions/security/packages/storybook/config @elastic/security-threat-hunting-explore
x-pack/solutions/security/packages/upselling @elastic/security-threat-hunting-explore
x-pack/test/security_functional/plugins/test_endpoints @elastic/kibana-security
x-pack/packages/security/ui_components @elastic/kibana-security
x-pack/platform/packages/private/security/ui_components @elastic/kibana-security
x-pack/solutions/security/packages/kbn-securitysolution-autocomplete @elastic/security-detection-engine
x-pack/solutions/security/packages/data_table @elastic/security-threat-hunting-investigations
src/platform/packages/shared/kbn-securitysolution-ecs @elastic/security-threat-hunting-explore
Expand Down Expand Up @@ -925,7 +925,7 @@ x-pack/platform/plugins/private/snapshot_restore @elastic/kibana-management
packages/kbn-some-dev-log @elastic/kibana-operations
packages/kbn-sort-package-json @elastic/kibana-operations
packages/kbn-sort-predicates @elastic/kibana-visualizations
x-pack/plugins/spaces @elastic/kibana-security
x-pack/platform/plugins/shared/spaces @elastic/kibana-security
x-pack/test/spaces_api_integration/common/plugins/spaces_test_plugin @elastic/kibana-security
packages/kbn-spec-to-console @elastic/kibana-management
src/platform/packages/shared/kbn-sse-utils @elastic/obs-knowledge-team
Expand Down Expand Up @@ -1010,7 +1010,7 @@ src/plugins/url_forwarding @elastic/kibana-visualizations
src/platform/plugins/shared/usage_collection @elastic/kibana-core
test/plugin_functional/plugins/usage_collection @elastic/kibana-core
packages/kbn-use-tracked-promise @elastic/obs-ux-logs-team
packages/kbn-user-profile-components @elastic/kibana-security
src/platform/packages/shared/kbn-user-profile-components @elastic/kibana-security
examples/user_profile_examples @elastic/kibana-security
x-pack/test/security_api_integration/plugins/user_profiles_consumer @elastic/kibana-security
src/platform/packages/shared/kbn-utility-types @elastic/kibana-core
Expand Down Expand Up @@ -1482,7 +1482,7 @@ x-pack/platform/plugins/private/cloud_integrations/cloud_full_story/server/confi
/x-pack/test_serverless/**/test_suites/security/platform_security/ @elastic/kibana-security
/x-pack/test_serverless/**/test_suites/observability/platform_security/ @elastic/kibana-security
/src/core/packages/http/server-internal/src/cdn_config/ @elastic/kibana-security @elastic/kibana-core
#CC# /x-pack/plugins/security/ @elastic/kibana-security
#CC# /x-pack/platform/plugins/shared/security/ @elastic/kibana-security

# Response Ops team
/x-pack/test/functional/es_archives/cases/default @elastic/response-ops
Expand Down Expand Up @@ -1894,7 +1894,6 @@ x-pack/plugins/osquery @elastic/security-defend-workflows
/x-pack/solutions/security/plugins/security_solution/public/cloud_defend @elastic/kibana-cloud-security-posture

# Cloud Security Posture
x-pack/solutions/security/packages/distribution_bar @elastic/kibana-cloud-security-posture
x-pack/packages/kbn-cloud-security-posture @elastic/kibana-cloud-security-posture
/x-pack/test_serverless/functional/test_suites/security/config.cloud_security_posture.* @elastic/kibana-cloud-security-posture
/x-pack/solutions/security/plugins/security_solution/public/cloud_security_posture @elastic/kibana-cloud-security-posture
Expand Down
4 changes: 2 additions & 2 deletions .i18nrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"inputControl": "src/platform/plugins/private/input_control_vis",
"inspector": "src/platform/plugins/shared/inspector",
"inspectorViews": "src/legacy/core_plugins/inspector_views",
"interactiveSetup": "src/plugins/interactive_setup",
"interactiveSetup": "src/platform/plugins/private/interactive_setup",
"interpreter": "src/legacy/core_plugins/interpreter",
"imageEmbeddable": "src/platform/plugins/private/image_embeddable",
"kbn": "src/legacy/core_plugins/kibana",
Expand Down Expand Up @@ -143,7 +143,7 @@
"uiActionsEnhanced": "src/platform/plugins/shared/ui_actions_enhanced",
"uiActionsExamples": "examples/ui_action_examples",
"usageCollection": "src/platform/plugins/shared/usage_collection",
"userProfileComponents": "packages/kbn-user-profile-components",
"userProfileComponents": "src/platform/packages/shared/kbn-user-profile-components",
"utils": "x-pack/solutions/security/packages/kbn-securitysolution-utils/src",
"visDefaultEditor": "src/plugins/vis_default_editor",
"visTypeGauge": "src/plugins/vis_types/gauge",
Expand Down
Loading
Loading