[ECO][Inventory v2] Remove the landing page to enable the entity model #205534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion endpoint using sources (elastic#203424)" This reverts commit 5bacf1f.
jennypavlova
added
release_note:skip
…ge-to-enable-the-entity-model
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
kpatticha
reviewed
Jan 6, 2025
| useEuiTheme, | ||
| COLOR_MODES_STANDARD, | ||
| } from '@elastic/eui'; | ||
| import inventoryLight from '../../assets/entities_inventory_light.png'; |
There was a problem hiding this comment.
Can we remove these images since they're not being used?
There was a problem hiding this comment.
Good catch, thanks! Removed here :)
kpatticha
approved these changes
Jan 6, 2025
…ge-to-enable-the-entity-model
…ge-to-enable-the-entity-model
…ge-to-enable-the-entity-model
…ge-to-enable-the-entity-model
…ge-to-enable-the-entity-model
…ge-to-enable-the-entity-model
…ge-to-enable-the-entity-model
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsmiscellaneous assets size
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 8, 2025
elastic#205534) Closes elastic#203095 Closes elastic#204263 ## Summary This PR removes the page for the enabling functionality and welcome screen. After the migration to v2 API we don't need to enable it anymore as we are not using transforms ### Before:   ### After: The same without the extra step to enable the entities and the welcome screen: - No data:  - With data:  ## Testing - In a local environment enable the entities feature flag ( it should be a clean env as the entities should not be enabled before ): <img width="1911" alt="image" src="https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e" /> - Go to Inventory - Check before and after ingesting data - Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this case can't be checked before elastic#203452 is merged~ - elastic#203452 is merged 🎉 (cherry picked from commit d6e28f7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 8, 2025
…y model (#205534) (#205958) # Backport This will backport the following commits from `main` to `8.x`: - [[ECO][Inventory v2] Remove the landing page to enable the entity model (#205534)](#205534) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T19:30:17Z","message":"[ECO][Inventory v2] Remove the landing page to enable the entity model (#205534)\n\nCloses #203095\r\nCloses https://github.com/elastic/kibana/issues/204263\r\n\r\n\r\n## Summary\r\n\r\nThis PR removes the page for the enabling functionality and welcome\r\nscreen. After the migration to v2 API we don't need to enable it anymore\r\nas we are not using transforms\r\n\r\n### Before: \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### After: \r\nThe same without the extra step to enable the entities and the welcome\r\nscreen:\r\n- No data: \r\n\r\n\r\n\r\n- With data:\r\n\r\n\r\n\r\n## Testing\r\n\r\n- In a local environment enable the entities feature flag ( it should be\r\na clean env as the entities should not be enabled before ):\r\n<img width=\"1911\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e\"\r\n/>\r\n\r\n- Go to Inventory \r\n- Check before and after ingesting data\r\n- Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this\r\ncase can't be checked before\r\nhttps://github.com//pull/203452 is merged~ -\r\nhttps://github.com//pull/203452 is merged 🎉","sha":"d6e28f766ac5363b4a6888871a2813538a4ee367","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"title":"[ECO][Inventory v2] Remove the landing page to enable the entity model","number":205534,"url":"https://github.com/elastic/kibana/pull/205534","mergeCommit":{"message":"[ECO][Inventory v2] Remove the landing page to enable the entity model (#205534)\n\nCloses #203095\r\nCloses https://github.com/elastic/kibana/issues/204263\r\n\r\n\r\n## Summary\r\n\r\nThis PR removes the page for the enabling functionality and welcome\r\nscreen. After the migration to v2 API we don't need to enable it anymore\r\nas we are not using transforms\r\n\r\n### Before: \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### After: \r\nThe same without the extra step to enable the entities and the welcome\r\nscreen:\r\n- No data: \r\n\r\n\r\n\r\n- With data:\r\n\r\n\r\n\r\n## Testing\r\n\r\n- In a local environment enable the entities feature flag ( it should be\r\na clean env as the entities should not be enabled before ):\r\n<img width=\"1911\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e\"\r\n/>\r\n\r\n- Go to Inventory \r\n- Check before and after ingesting data\r\n- Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this\r\ncase can't be checked before\r\nhttps://github.com//pull/203452 is merged~ -\r\nhttps://github.com//pull/203452 is merged 🎉","sha":"d6e28f766ac5363b4a6888871a2813538a4ee367"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205534","number":205534,"mergeCommit":{"message":"[ECO][Inventory v2] Remove the landing page to enable the entity model (#205534)\n\nCloses #203095\r\nCloses https://github.com/elastic/kibana/issues/204263\r\n\r\n\r\n## Summary\r\n\r\nThis PR removes the page for the enabling functionality and welcome\r\nscreen. After the migration to v2 API we don't need to enable it anymore\r\nas we are not using transforms\r\n\r\n### Before: \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### After: \r\nThe same without the extra step to enable the entities and the welcome\r\nscreen:\r\n- No data: \r\n\r\n\r\n\r\n- With data:\r\n\r\n\r\n\r\n## Testing\r\n\r\n- In a local environment enable the entities feature flag ( it should be\r\na clean env as the entities should not be enabled before ):\r\n<img width=\"1911\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e\"\r\n/>\r\n\r\n- Go to Inventory \r\n- Check before and after ingesting data\r\n- Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this\r\ncase can't be checked before\r\nhttps://github.com//pull/203452 is merged~ -\r\nhttps://github.com//pull/203452 is merged 🎉","sha":"d6e28f766ac5363b4a6888871a2813538a4ee367"}}]}] BACKPORT--> Co-authored-by: jennypavlova <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
elastic#205534) Closes elastic#203095 Closes elastic#204263 ## Summary This PR removes the page for the enabling functionality and welcome screen. After the migration to v2 API we don't need to enable it anymore as we are not using transforms ### Before:   ### After: The same without the extra step to enable the entities and the welcome screen: - No data:  - With data:  ## Testing - In a local environment enable the entities feature flag ( it should be a clean env as the entities should not be enabled before ): <img width="1911" alt="image" src="https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e" /> - Go to Inventory - Check before and after ingesting data - Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this case can't be checked before elastic#203452 is merged~ - elastic#203452 is merged 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #203095
Closes #204263
Summary
This PR removes the page for the enabling functionality and welcome screen. After the migration to v2 API we don't need to enable it anymore as we are not using transforms
Before:
After:
The same without the extra step to enable the entities and the welcome screen:
No data:
With data:
Testing
node scripts/synthtrace logs_traces_hosts.ts-⚠️ this case can't be checked before [ECO] Use new Entity v2 endpoints in Inventory #203452 is merged