Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uiActions] make trigger action registry async #205512

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

[uiActions] make trigger action registry async #205512

wants to merge 24 commits into from

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 3, 2025 •
edited
Loading

Closes #191642

PR makes the following changes to uiActions API.

  • Deprecates registerAction and addTriggerAction and replaces them with registerActionAsync and addTriggerActionAsync
  • Makes all registry consumption methods async, such as getAction, getTriggerActions and getFrequentlyChangingActionsForTrigger

PR also updates presentation_panel plugin to demonstrate how registerActionAsync should be used to clean-up page load size.

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@nreese
Copy link
Contributor Author

nreese commented Jan 3, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 3, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 3, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 3, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 3, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 3, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 4, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 4, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Jan 4, 2025

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 4, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #62 / discover/group4 adhoc data views should notify about invalid filter reffs
  • [job] [logs] FTR Configs #67 / discover/group4 adhoc data views should notify about invalid filter reffs
  • [job] [logs] FTR Configs #68 / discover/group4 adhoc data views should notify about invalid filter reffs
  • [job] [logs] FTR Configs #99 / discover/group4 adhoc data views should notify about invalid filter reffs
  • [job] [logs] FTR Configs #62 / discover/group4 adhoc data views should notify about invalid filter reffs
  • [job] [logs] FTR Configs #68 / discover/group4 adhoc data views should notify about invalid filter reffs
  • [job] [logs] FTR Configs #67 / discover/group4 adhoc data views should notify about invalid filter reffs
  • [job] [logs] FTR Configs #99 / discover/group4 adhoc data views should notify about invalid filter reffs
  • [job] [logs] Jest Tests #10 / filters notification popover calls edit action execute when edit button is clicked
  • [job] [logs] Jest Tests #10 / filters notification popover calls edit action execute when edit button is clicked

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
presentationPanel 100 113 +13

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
presentationPanel 11 9 -2
uiActions 110 117 +7
total +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 596.3KB 596.4KB +13.0B
discover 782.3KB 782.3KB +11.0B
lens 1.5MB 1.5MB +30.0B
maps 3.0MB 3.0MB +40.0B
presentationPanel 15.6KB 42.1KB +26.5KB
total +26.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 49.1KB 49.2KB +163.0B
presentationPanel 40.8KB 19.5KB -21.3KB
presentationUtil 30.9KB 31.0KB +11.0B
uiActions 21.5KB 22.0KB +564.0B
total -20.6KB
Unknown metric groups

API count

id before after diff
presentationPanel 11 9 -2
uiActions 156 163 +7
total +5

async chunk count

id before after diff
presentationPanel 1 5 +4

ESLint disabled line counts

id before after diff
dashboard 10 11 +1
presentationPanel 6 7 +1
total +2

References to deprecated APIs

id before after diff
aiops 4 9 +5
cases 31 32 +1
controls 13 16 +3
dashboard 21 30 +9
dashboardEnhanced 9 11 +2
data 29 32 +3
discover 8 10 +2
discoverEnhanced 0 2 +2
esql 0 1 +1
imageEmbeddable 1 2 +1
inputControlVis 10 11 +1
lens 85 92 +7
links 3 4 +1
maps 30 33 +3
ml 35 53 +18
reporting 4 5 +1
securitySolution 464 471 +7
slo 3 7 +4
synthetics 20 22 +2
uiActionsEnhanced 11 12 +1
unifiedSearch 13 15 +2
visualizations 55 57 +2
total +78

Total ESLint disabled count

id before after diff
dashboard 10 11 +1
presentationPanel 6 7 +1
total +2

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[uiActions] make trigger action registry async
3 participants
@nreese @elasticmachine @kibanamachine