-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
register 8.x deprecations #205500
register 8.x deprecations #205500
Conversation
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/index.ts
Outdated
Show resolved
Hide resolved
This PR is now ready for review.
|
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/index.ts
Outdated
Show resolved
Hide resolved
@seanstory - Overall, I think this is a great start, and I see that this will actually work for the pieces that we need for surfacing the critical for any Enterprise Search nodes. We had talked about adding in some context for the deployment type (Cloud, ECK, Self-Managed) and possibly changing some of the display text (and for Cloud adding a button to "manage your deployment") - Let me know your thoughts on if you'd want to add it to this PR, or, you would prefer a follow-on PR to this (that I'd probably do). Thanks! |
b122f5d
to
6750c82
Compare
I have some logic around this in here. For instance:
I don't recall this discussion, but I don't think this is possible through "registered deprecations." Note that my PR has 0 HTML, and my screenshots show off a framework feature that's powered by these javascript objects. I don't define the "quick resolve" button - that's automagically made for me when I have a
So I don't have a way to introduce another button, or hit a Cloud API. However, I believe that @andrew-moldovan had indicated that this same list of Deprecation messages are exposed through the Cloud portal. |
Ah - thanks! I missed that while going through the code. Nice.
I thought it was possible - I may be wrong. Would love to see what Andrew might know though. Thanks again. |
I do believe we show the output of what the Kibana upgrade_assistant status API gives us. This is something that we'll obviously need to test again once this has been merged, so I encourage you to do that. And let us know if it's not looking good and we can look into it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait until the 8.x docs page is live before merging this.
[EDIT: page is live]
page is now live, just need to re-run CI
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/index.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/index.ts
Show resolved
Hide resolved
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/index.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/index.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/index.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/routes.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/routes.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/routes.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/routes.test.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/search/plugins/enterprise_search/server/deprecations/routes.test.ts
Outdated
Show resolved
Hide resolved
…:elastic/kibana into seanstory/8364-register-8.x-deprecations
…:elastic/kibana into seanstory/8364-register-8.x-deprecations
…:elastic/kibana into seanstory/8364-register-8.x-deprecations
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
Summary
This PR adds "critical deprecations" to the kibana upgrade assistant. For the ones where we can easily/automatically take action for the user, we also provide new backend routes that these deprecations can hit directly.
Screenshots of what's been added, below.
Enterprise Search Node
Crawler "connector" records
Invalid "native" connector service types
Agentless not available
Fleet Server not available
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*
label is applied per the guidelines