Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register 8.x deprecations #205500

Merged
merged 46 commits into from
Jan 16, 2025
Merged

Conversation

seanstory
Copy link
Member

@seanstory seanstory commented Jan 3, 2025

Summary

This PR adds "critical deprecations" to the kibana upgrade assistant. For the ones where we can easily/automatically take action for the user, we also provide new backend routes that these deprecations can hit directly.

Screenshots of what's been added, below.

Screenshot 2025-01-07 at 10 30 50 AM

Enterprise Search Node

Screenshot 2025-01-08 at 2 23 07 PM

Crawler "connector" records

Screenshot 2025-01-08 at 2 24 53 PM

Invalid "native" connector service types

Screenshot 2025-01-08 at 2 25 54 PM

Agentless not available

Screenshot 2025-01-08 at 2 28 05 PM

Fleet Server not available

Screenshot 2025-01-08 at 2 26 22 PM

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@seanstory seanstory added v8.18.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 7, 2025
@seanstory seanstory marked this pull request as ready for review January 7, 2025 16:58
@seanstory seanstory added the backport:skip This commit does not require backporting label Jan 7, 2025
@seanstory seanstory requested review from markjhoy, leemthompo, danajuratoni and a team January 7, 2025 16:59
@seanstory
Copy link
Member Author

This PR is now ready for review.

  • @danajuratoni @leemthompo I'd love your help with making sure the copy looks right for upgrade guidance.
  • @markjhoy tagging you for review as you're overseeing a lot of the decomissioning work, and I could see this being a home/pattern for additional deprecations that need to be added.

@markjhoy
Copy link
Contributor

markjhoy commented Jan 7, 2025

@seanstory - Overall, I think this is a great start, and I see that this will actually work for the pieces that we need for surfacing the critical for any Enterprise Search nodes.

We had talked about adding in some context for the deployment type (Cloud, ECK, Self-Managed) and possibly changing some of the display text (and for Cloud adding a button to "manage your deployment") - Let me know your thoughts on if you'd want to add it to this PR, or, you would prefer a follow-on PR to this (that I'd probably do). Thanks!

@seanstory seanstory force-pushed the seanstory/8364-register-8.x-deprecations branch from b122f5d to 6750c82 Compare January 7, 2025 19:17
@seanstory
Copy link
Member Author

We had talked about adding in some context for the deployment type (Cloud, ECK, Self-Managed)

I have some logic around this in here. For instance:

for Cloud adding a button to "manage your deployment"

I don't recall this discussion, but I don't think this is possible through "registered deprecations." Note that my PR has 0 HTML, and my screenshots show off a framework feature that's powered by these javascript objects. I don't define the "quick resolve" button - that's automagically made for me when I have a

correctiveActions: {
  api: {
    path: <Kibana API Path>
  }
}

So I don't have a way to introduce another button, or hit a Cloud API.

However, I believe that @andrew-moldovan had indicated that this same list of Deprecation messages are exposed through the Cloud portal.

@markjhoy
Copy link
Contributor

markjhoy commented Jan 7, 2025

I have some logic around this in here. For instance:

Ah - thanks! I missed that while going through the code. Nice.

So I don't have a way to introduce another button, or hit a Cloud API. However, I believe that @andrew-moldovan had indicated that this same list of Deprecation messages are exposed through the Cloud portal.

I thought it was possible - I may be wrong. Would love to see what Andrew might know though. Thanks again.

@andrew-moldovan
Copy link

I do believe we show the output of what the Kibana upgrade_assistant status API gives us. This is something that we'll obviously need to test again once this has been merged, so I encourage you to do that. And let us know if it's not looking good and we can look into it

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until the 8.x docs page is live before merging this.

[EDIT: page is live]

@leemthompo leemthompo dismissed their stale review January 10, 2025 15:11

page is now live, just need to re-run CI

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 16, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1312 1315 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 96.7KB 96.7KB +38.0B
lists 146.5KB 146.6KB +38.0B
total +76.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 448.7KB 448.8KB +38.0B
enterpriseSearch 53.2KB 53.3KB +145.0B
total +183.0B
Unknown metric groups

API count

id before after diff
fleet 1440 1444 +4

History

@seanstory seanstory merged commit f62618e into 8.x Jan 16, 2025
8 checks passed
@seanstory seanstory deleted the seanstory/8364-register-8.x-deprecations branch January 16, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants