Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waitUntilLoadingHasFinished in failing tests #205485

Merged
merged 10 commits into from
Jan 8, 2025
+31 −51
Merged

Add waitUntilLoadingHasFinished in failing tests #205485

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
76e9524
Add waitUntilLoadingHasFinished in failing tests
SoniaSanzV Jan 3, 2025
1f64ad6
Merge branch 'main' into fix_logsdb_tests
SoniaSanzV Jan 3, 2025
aa8459e
Add fixes for data_streams tests in serverless
SoniaSanzV Jan 3, 2025
847b50d
Add selector
SoniaSanzV Jan 3, 2025
1f0fd73
Merge branch 'main' into fix_logsdb_tests
SoniaSanzV Jan 3, 2025
c4d0859
Merge branch 'main' into fix_logsdb_tests
SoniaSanzV Jan 7, 2025
97cdfe8
Jump to the tab by number
SoniaSanzV Jan 7, 2025
abae15c
Merge branch 'main' into fix_logsdb_tests
SoniaSanzV Jan 7, 2025
33d009d
Merge branch 'main' into fix_logsdb_tests
SoniaSanzV Jan 7, 2025
7a2155e
Jump to tab 5 in index_template_tab test
SoniaSanzV Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ment/public/application/sections/home/template_list/template_details/tabs/tab_summary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ export const TabSummary: React.FunctionComponent<Props> = ({ templateDetails })
defaultMessage="Index mode"
/>
</EuiDescriptionListTitle>
<EuiDescriptionListDescription>
<EuiDescriptionListDescription data-test-subj="indexModeValue">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test subject used somewhere?

Copy link
Contributor Author

@SoniaSanzV SoniaSanzV Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is used. So I don't know why they were passing when I was running them locally 🫠

{indexModeLabels[indexMode]}
</EuiDescriptionListDescription>
</>
Expand Down
4 changes: 4 additions & 0 deletions x-pack/test/functional/apps/index_management/data_streams_tab/data_streams_tab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,10 +278,12 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
};

const verifyModeHasBeenChanged = async (indexModeName: string) => {
await pageObjects.header.waitUntilLoadingHasFinished();
expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);

// Click update template
await pageObjects.indexManagement.clickNextButton();
await pageObjects.header.waitUntilLoadingHasFinished();

// Verify index mode and close detail tab
expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
Expand Down Expand Up @@ -359,6 +361,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue('kibanaCodeEditor', '{}', {
clearWithKeyboard: true,
Expand All @@ -381,6 +384,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue(
'kibanaCodeEditor',
Expand Down
2 changes: 2 additions & 0 deletions x-pack/test/functional/apps/index_management/index_templates_tab/index_template_tab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await pageObjects.header.waitUntilLoadingHasFinished();

expect(await testSubjects.getVisibleText('lifecycleValue')).to.be('7 hours');

Expand All @@ -76,6 +77,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await pageObjects.header.waitUntilLoadingHasFinished();

expect(await testSubjects.exists('indexModeTitle')).to.be(true);
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');
Expand Down
4 changes: 4 additions & 0 deletions ...test_serverless/functional/test_suites/common/management/index_management/data_streams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,12 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
};

const verifyModeHasBeenChanged = async (indexModeName: string) => {
await pageObjects.header.waitUntilLoadingHasFinished();
expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);

// Click update template
await pageObjects.indexManagement.clickNextButton();
await pageObjects.header.waitUntilLoadingHasFinished();

// Verify index mode and close detail tab
expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
Expand Down Expand Up @@ -283,6 +285,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue('kibanaCodeEditor', '{}', {
clearWithKeyboard: true,
Expand All @@ -305,6 +308,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

await testSubjects.click('nextButton');
await testSubjects.click('nextButton');
await pageObjects.header.waitUntilLoadingHasFinished();
// Modify Index settings
await testSubjects.setValue(
'kibanaCodeEditor',
Expand Down
2 changes: 2 additions & 0 deletions ...t_serverless/functional/test_suites/common/management/index_management/index_templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,12 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

// Click form summary step and then the submit button
await testSubjects.click('formWizardStep-5');
await pageObjects.header.waitUntilLoadingHasFinished();
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');

// Click update template
await pageObjects.indexManagement.clickNextButton();
await pageObjects.header.waitUntilLoadingHasFinished();

// Close detail tab
expect(await testSubjects.getVisibleText('indexModeValue')).to.be('LogsDB');
Expand Down