[8.x] [Kibana Overview] Shift SCSS import and lazy-load main component (#204661) #205484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#204661) ## Summary Part of elastic/kibana-team#1082 The purpose of this PR is to reduce the page load bundle size of the `kibanaOverview` plugin. Converts the main component of the `kibanaOverview` plugin to be lazy loaded, and shifts the import of the main SCSS file to be imported from the lazily-loaded component. This PR does not include any changes that would be noticeable by end-users. It changes the internals to use a different technology for styling components. ## References 1. https://emotion.sh/docs/globals 2. https://emotion.sh/docs/best-practices 3. elastic/eui#6828 (comment) (cherry picked from commit 1861bbc)
kibanamachine
force-pushed
the
backport/8.x/pr-204661
branch
from
384daf2 to
2423b0e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
cc @tsullivan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation