Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MKI] Fix flaky search source alert test #205481

Merged
merged 6 commits into from
Jan 7, 2025
Merged

[MKI] Fix flaky search source alert test #205481

merged 6 commits into from
Jan 7, 2025

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Jan 3, 2025 •
edited
Loading

Summary

Use settings method instead of naive typing.
Naive only because the asterisk at the end of the text box is better handled in the settings method.

@wayneseymour
[MKI] Fix flaky search source alert test
97ec452 
Based on fact that a backend request is fired everytime the text box is
typed in, let's wait for loading to finish after we type.
@wayneseymour wayneseymour added the failed-test A test failure on a tracked branch, potentially flaky-test label Jan 3, 2025
@wayneseymour wayneseymour self-assigned this Jan 3, 2025
@wayneseymour wayneseymour requested a review from a team as a code owner January 3, 2025 11:55
@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jan 3, 2025
davismcphee
davismcphee approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! I did not manually test in MKI, but I followed the Slack thread and the change makes sense to me.

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour wayneseymour enabled auto-merge (squash) January 7, 2025 10:36
@wayneseymour wayneseymour merged commit fbc033c into elastic:main Jan 7, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @wayneseymour

@wayneseymour wayneseymour deleted the fix-search-src-alert branch January 7, 2025 12:03
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
@wayneseymour @kowalczyk-krzysztof
[MKI] Fix flaky search source alert test (elastic#205481)
ddceafa 
## Summary

Use settings
[method](https://github.com/elastic/kibana/blob/c8d46ee94982cf38163786f0890bafd43ec07247/test/functional/page_objects/settings_page.ts#L648)
instead of naive typing.
Naive only because the asterisk at the end of the text box is better
handled in the settings method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@wayneseymour wayneseymour

Labels
backport:skip This commit does not require backporting failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wayneseymour @elasticmachine @davismcphee @kibanamachine