[8.x] Handle Json in Set and Append Value field (#204336) #205470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Closes [elastic#193186](elastic#193186) ## Sumary This PR introduces changes in two processors: Set y Append. The aim of this changes is to allow introducing the Value field in both processors in Json format. Now, Set accepts Text format or Json and Append a list of values or Json. The toggle between the format is done by the new Label Append button. <img width="705" alt="Screenshot 2024-12-16 at 07 30 11" src="https://github.com/user-attachments/assets/0f6283ed-6117-48d8-bdd8-e0685ae1b42d" /> Also, since the Set processor already had a Label Append button for toggling between the `Value` and the `Copy_from` field, this now has been replaced by a toggle button that enables a field for the `Copy_from` field (see the last comments in the related Issue for see the most updated mocks). <img width="708" alt="Screenshot 2024-12-16 at 07 30 49" src="https://github.com/user-attachments/assets/4a632bda-4b4b-49b1-b3d4-d11579d7c27c" /> Note: the Set copies still pending review so probably will be changed. ### Demo https://github.com/user-attachments/assets/f9d1da6a-782d-4197-836b-fab46b4476b7 (cherry picked from commit 59b2292)
kibanamachine
force-pushed
the
backport/8.x/pr-204336
branch
from
9493afb to
e22de77
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
cc @SoniaSanzV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation