Update Cytoscape (main) - abandoned #205444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![elastic-renovate-prod[bot]](https://avatars.githubusercontent.com/in/937301?s=60&v=4){kind=small}
elastic-renovate-prod
bot
added
backport:all-open
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
/ci |
⏳ Build in-progress, with failures
Failed CI Steps |
|
It seems the update contained a semver breaking change in the typing for the packages (I love semver breakages). We can't merge this PR without some changes. |
Bluefinger
added a commit
that referenced
this pull request
Jan 8, 2025
…205726) ## Summary Updates Cytoscape to newer versions, requiring one change with some `removeListener` usage no longer being valid typing. Supersedes #205444 ## How to test - Passes CI with no type errors or failed CI jobs for ML - Job Map or wherever cytoscape is being used on ML doesn't leak event listeners. - Usages in APM also do not break.
|
Closed in favour of #205726 |
elastic-renovate-prod
bot
changed the title
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
Bluefinger
added a commit
to Bluefinger/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205726) ## Summary Updates Cytoscape to newer versions, requiring one change with some `removeListener` usage no longer being valid typing. Supersedes elastic#205444 ## How to test - Passes CI with no type errors or failed CI jobs for ML - Job Map or wherever cytoscape is being used on ML doesn't leak event listeners. - Usages in APM also do not break. (cherry picked from commit 7363f03) # Conflicts: # x-pack/solutions/observability/plugins/apm/public/components/app/service_map/cytoscape_options.ts # yarn.lock
Bluefinger
added a commit
to Bluefinger/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205726) ## Summary Updates Cytoscape to newer versions, requiring one change with some `removeListener` usage no longer being valid typing. Supersedes elastic#205444 ## How to test - Passes CI with no type errors or failed CI jobs for ML - Job Map or wherever cytoscape is being used on ML doesn't leak event listeners. - Usages in APM also do not break. (cherry picked from commit 7363f03) # Conflicts: # package.json # x-pack/plugins/observability_solution/apm/public/components/app/service_map/cytoscape_options.ts # yarn.lock
Bluefinger
added a commit
to Bluefinger/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205726) ## Summary Updates Cytoscape to newer versions, requiring one change with some `removeListener` usage no longer being valid typing. Supersedes elastic#205444 ## How to test - Passes CI with no type errors or failed CI jobs for ML - Job Map or wherever cytoscape is being used on ML doesn't leak event listeners. - Usages in APM also do not break. (cherry picked from commit 7363f03) # Conflicts: # package.json # x-pack/plugins/observability_solution/apm/public/components/app/service_map/cytoscape_options.ts # yarn.lock
Bluefinger
added a commit
to Bluefinger/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205726) ## Summary Updates Cytoscape to newer versions, requiring one change with some `removeListener` usage no longer being valid typing. Supersedes elastic#205444 ## How to test - Passes CI with no type errors or failed CI jobs for ML - Job Map or wherever cytoscape is being used on ML doesn't leak event listeners. - Usages in APM also do not break.
Bluefinger
added a commit
that referenced
this pull request
Jan 8, 2025
…ons (#205726) (#205848) # Backport This will backport the following commits from `main` to `8.x`: - [[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)](#205726) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T09:16:17Z","message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions","number":205726,"url":"https://github.com/elastic/kibana/pull/205726","mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205726","number":205726,"mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}}]}] BACKPORT-->
Bluefinger
added a commit
that referenced
this pull request
Jan 8, 2025
…ions (#205726) (#205850) # Backport This will backport the following commits from `main` to `8.17`: - [[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)](#205726) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T09:16:17Z","message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions","number":205726,"url":"https://github.com/elastic/kibana/pull/205726","mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205726","number":205726,"mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}}]}] BACKPORT-->
Bluefinger
added a commit
that referenced
this pull request
Jan 8, 2025
…ions (#205726) (#205854) # Backport This will backport the following commits from `main` to `8.16`: - [[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)](#205726) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T09:16:17Z","message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions","number":205726,"url":"https://github.com/elastic/kibana/pull/205726","mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205726","number":205726,"mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}}]}] BACKPORT-->
Bluefinger
added a commit
that referenced
this pull request
Jan 8, 2025
…ions (#205726) (#205867) # Backport This will backport the following commits from `main` to `7.17`: - [[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)](#205726) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T09:16:17Z","message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions","number":205726,"url":"https://github.com/elastic/kibana/pull/205726","mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205726","number":205726,"mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}}]}] BACKPORT-->
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205726) ## Summary Updates Cytoscape to newer versions, requiring one change with some `removeListener` usage no longer being valid typing. Supersedes elastic#205444 ## How to test - Passes CI with no type errors or failed CI jobs for ML - Job Map or wherever cytoscape is being used on ML doesn't leak event listeners. - Usages in APM also do not break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^3.14.0->^3.21.8^3.10.0->^3.30.4^2.2.2->^2.5.0Release Notes
cytoscape/cytoscape.js (cytoscape)
v3.30.4Compare Source
Release version v3.30.4
v3.30.3Compare Source
v3.30.2Compare Source
Release version v3.30.2
v3.30.1Compare Source
Release version v3.30.1
v3.30.0Compare Source
Release version v3.30.0
v3.29.3Compare Source
Release version v3.29.3
v3.29.2Compare Source
Release version v3.29.2
v3.29.1Compare Source
Release version v3.29.1
v3.29.0Compare Source
Release version v3.29.0
v3.28.1Compare Source
Release version v3.28.1
v3.28.0Compare Source
Release version v3.28.0
v3.27.2Compare Source
Release version v3.27.2
v3.27.1Compare Source
Release version v3.27.1
v3.27.0Compare Source
Release version v3.27.0
v3.26.2Compare Source
Release version v3.26.2
v3.26.1Compare Source
Release version v3.26.1
v3.26.0Compare Source
v3.25.2Compare Source
Release version v3.25.2
v3.25.1Compare Source
v3.25.0Compare Source
v3.24.2Compare Source
v3.24.1Compare Source
v3.24.0Compare Source
v3.23.1Compare Source
v3.23.0Compare Source
v3.22.1Compare Source
v3.22.0Compare Source
v3.21.3Compare Source
v3.21.2Compare Source
v3.21.1Compare Source
v3.21.0Compare Source
v3.20.3Compare Source
v3.20.2Compare Source
v3.20.1Compare Source
v3.20.0Compare Source
v3.19.1Compare Source
v3.19.0Compare Source
v3.18.3Compare Source
v3.18.2Compare Source
v3.18.1Compare Source
v3.18.0Compare Source
v3.17.4Compare Source
v3.17.3Compare Source
v3.17.2Compare Source
v3.17.1Compare Source
v3.17.0Compare Source
v3.16.5Compare Source
v3.16.4Compare Source
v3.16.3Compare Source
v3.16.2Compare Source
v3.16.1Compare Source
v3.16.0Compare Source
v3.15.5Compare Source
v3.15.4Compare Source
v3.15.3Compare Source
v3.15.2Compare Source
v3.15.1Compare Source
v3.15.0Compare Source
v3.14.4Compare Source
v3.14.3Compare Source
v3.14.2Compare Source
v3.14.1Compare Source
v3.14.0Compare Source
v3.13.3Compare Source
v3.13.2Compare Source
v3.13.1Compare Source
v3.13.0Compare Source
v3.12.3Compare Source
v3.12.2Compare Source
v3.12.1Compare Source
v3.12.0Compare Source
v3.11.2Compare Source
v3.11.1Compare Source
v3.11.0Compare Source
v3.10.2Compare Source
v3.10.1Compare Source
cytoscape/cytoscape.js-dagre (cytoscape-dagre)
v2.5.0Compare Source
v2.4.0Compare Source
v2.3.2Compare Source
v2.3.1Compare Source
v2.3.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Renovate Bot.