Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.x mirror of [Security Solution][Detection Engine] fixes reindexed .list(from 7.x) index migration to DS #205359

Closed
wants to merge 5 commits into from
Closed

8.x mirror of [Security Solution][Detection Engine] fixes reindexed .list(from 7.x) index migration to DS #205359

wants to merge 5 commits into from

Conversation

vitaliidm
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@vitaliidm vitaliidm mentioned this pull request Jan 7, 2025
Merged
@vitaliidm vitaliidm closed this Jan 13, 2025
vitaliidm added a commit that referenced this pull request Jan 13, 2025
@vitaliidm @kibanamachine @rylnd
[Security Solution][Detection Engine] fixes reindexed .list(from 7.x)…
6d386b5 
… index migration to DS (#204945)

## Summary

- addresses elastic/security-team#11414


### Testing

1. Create cloud env of 7.x version
2. Upload list items
3. Create cloud env of 8.18 from existing 7.x snapshot (from previous
steps)
4. Connect local Kibana of 8.18 from mirror branch of this
one(#205359)
5. Add to Kibana dev config following options to enable Upgrade
assistant(UA) showing outdated indices
    ```yml
    xpack.upgrade_assistant.featureSet:
      mlSnapshots: true
      migrateDataStreams: true
      migrateSystemIndices: true
      reindexCorrectiveActions: true
    ```  
6. When Kibana started DO NOT visit Detection rule or any Security  page
7. Open KIbana Upgrade Assistant, check Elasticsearch deprecations
8. Find outdated .lists-* and .items-* index
9. Migrate them
10. Visit detection page to ensure list indices moved to data stream
stream and lists functionality is available: view, upload delete, etc

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Ryland Herrick <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 13, 2025
@vitaliidm
[Security Solution][Detection Engine] fixes reindexed .list(from 7.x)…
e11b6f8 
… index migration to DS (elastic#204945)

## Summary

- addresses elastic/security-team#11414

### Testing

1. Create cloud env of 7.x version
2. Upload list items
3. Create cloud env of 8.18 from existing 7.x snapshot (from previous
steps)
4. Connect local Kibana of 8.18 from mirror branch of this
one(elastic#205359)
5. Add to Kibana dev config following options to enable Upgrade
assistant(UA) showing outdated indices
    ```yml
    xpack.upgrade_assistant.featureSet:
      mlSnapshots: true
      migrateDataStreams: true
      migrateSystemIndices: true
      reindexCorrectiveActions: true
    ```
6. When Kibana started DO NOT visit Detection rule or any Security  page
7. Open KIbana Upgrade Assistant, check Elasticsearch deprecations
8. Find outdated .lists-* and .items-* index
9. Migrate them
10. Visit detection page to ensure list indices moved to data stream
stream and lists functionality is available: view, upload delete, etc

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Ryland Herrick <[email protected]>
(cherry picked from commit 6d386b5)
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 13, 2025
@vitaliidm @kibanamachine
@rylnd @delanni
[Security Solution][Detection Engine] fixes reindexed .list(from 7.x)…
13d6215 
… index migration to DS (elastic#204945)

## Summary

- addresses elastic/security-team#11414


### Testing

1. Create cloud env of 7.x version
2. Upload list items
3. Create cloud env of 8.18 from existing 7.x snapshot (from previous
steps)
4. Connect local Kibana of 8.18 from mirror branch of this
one(elastic#205359)
5. Add to Kibana dev config following options to enable Upgrade
assistant(UA) showing outdated indices
    ```yml
    xpack.upgrade_assistant.featureSet:
      mlSnapshots: true
      migrateDataStreams: true
      migrateSystemIndices: true
      reindexCorrectiveActions: true
    ```  
6. When Kibana started DO NOT visit Detection rule or any Security  page
7. Open KIbana Upgrade Assistant, check Elasticsearch deprecations
8. Find outdated .lists-* and .items-* index
9. Migrate them
10. Visit detection page to ensure list indices moved to data stream
stream and lists functionality is available: view, upload delete, etc

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Ryland Herrick <[email protected]>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@vitaliidm @kibanamachine
@rylnd @viduni94
[Security Solution][Detection Engine] fixes reindexed .list(from 7.x)…
ab7ef10 
… index migration to DS (elastic#204945)

## Summary

- addresses elastic/security-team#11414


### Testing

1. Create cloud env of 7.x version
2. Upload list items
3. Create cloud env of 8.18 from existing 7.x snapshot (from previous
steps)
4. Connect local Kibana of 8.18 from mirror branch of this
one(elastic#205359)
5. Add to Kibana dev config following options to enable Upgrade
assistant(UA) showing outdated indices
    ```yml
    xpack.upgrade_assistant.featureSet:
      mlSnapshots: true
      migrateDataStreams: true
      migrateSystemIndices: true
      reindexCorrectiveActions: true
    ```  
6. When Kibana started DO NOT visit Detection rule or any Security  page
7. Open KIbana Upgrade Assistant, check Elasticsearch deprecations
8. Find outdated .lists-* and .items-* index
9. Migrate them
10. Visit detection page to ensure list indices moved to data stream
stream and lists functionality is available: view, upload delete, etc

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Ryland Herrick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine will be requested when the pull request is marked ready for review kibanamachine is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitaliidm @elasticmachine