[AI Connector] Migrates AI inference Connector to use a shared components from '@kbn/inference-endpoint-ui-common' #204885

YulNaumenko · 2024-12-19T04:23:56Z

Migrated stack-connector .inference to use share UI components [Search] Add Inference endpoint Flyout in Inference Management UI #203204
Extended package @kbn/inference-endpoint-ui-common to support edit mode for the form of the connector, by adding the optional property isEdit to InferenceServiceFormFields component
Resolves flaky timing out test Failing test: Jest Tests.x-pack/plugins/stack_connectors/public/connector_types/inference - ConnectorFields renders Validation validates correctly if the provider config url is empty #205129

…tor through flyout

…fix'

…ents from '@kbn/inference-endpoint-ui-common'

…hared-ui-components # Conflicts: # .github/CODEOWNERS # package.json # tsconfig.base.json # x-pack/.i18nrc.json # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/additional_options_fields.tsx # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/configuration/configuration_field.tsx # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/configuration/configuration_form_items.tsx # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/configuration/configuration_utils.ts # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/alibaba_cloud.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/amazon_bedrock.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/anthropic.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/azure_ai_studio.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/azure_open_ai.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/cohere.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/elastic.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/google_ai_studio.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/hugging_face.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/ibm_watsonx.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/mistral.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/open_ai.svg # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.test.tsx # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/render_service_provider/service_provider.tsx # x-pack/packages/kbn-inference-endpoint-ui-common/src/components/providers/selectable.tsx # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/alibaba_cloud.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/amazon_bedrock.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/anthropic.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/azure_ai_studio.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/azure_open_ai.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/cohere.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/elastic.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/google_ai_studio.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/hugging_face.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/ibm_watsonx.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/mistral.svg # x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/providers/assets/images/open_ai.svg # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/additional_options_fields.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/providers/get_providers.test.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/providers/render_service_provider/service_provider.test.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/providers/render_service_provider/service_provider.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/providers/selectable/index.test.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/providers/selectable/index.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_field.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_form_items.tsx # x-pack/platform/plugins/shared/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_utils.ts # x-pack/plugins/stack_connectors/public/connector_types/inference/additional_options_fields.tsx # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/alibaba_cloud.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/amazon_bedrock.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/anthropic.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/azure_ai_studio.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/azure_open_ai.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/cohere.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/elastic.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/google_ai_studio.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/hugging_face.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/ibm_watsonx.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/mistral.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/assets/images/open_ai.svg # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/render_service_provider/service_provider.test.tsx # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/render_service_provider/service_provider.tsx # x-pack/plugins/stack_connectors/public/connector_types/inference/providers/selectable/index.tsx # x-pack/plugins/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_field.tsx # x-pack/plugins/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_form_items.tsx # x-pack/plugins/stack_connectors/public/connector_types/lib/dynamic_config/connector_configuration_utils.ts # x-pack/solutions/search/plugins/search_inference_endpoints/public/hooks/use_add_endpoint.test.tsx # x-pack/solutions/search/plugins/search_inference_endpoints/public/hooks/use_add_endpoint.ts # x-pack/solutions/search/plugins/search_inference_endpoints/public/hooks/use_providers.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/lib/add_inference_endpoint.test.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/lib/add_inference_endpoint.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/lib/fetch_inference_services.test.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/lib/fetch_inference_services.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/routes.ts # x-pack/solutions/search/plugins/search_inference_endpoints/server/utils/unflatten_object.ts # yarn.lock

…ulNaumenko/kibana into ai-connector-uses-shared-ui-components

stephmilovic

LGTM, thanks for the improvements!

ymao1 · 2025-01-03T20:38:06Z

x-pack/platform/plugins/shared/stack_connectors/public/connector_types/inference/connector.tsx

-    </>
-  );
+  return !isLoading ? (
+    <InferenceServiceFormFields providers={providers ?? []} isEdit={isEdit} />


since you're using the shared components now and it looks like the shared components have their own routes for getting the services configuration (hard-coded for now), should we also remove the server side routes in the stack_connectors folder?

Samiul-TheSoccerFan

LGTM

…he package

…apping'

…ulNaumenko/kibana into ai-connector-uses-shared-ui-components

elasticmachine · 2025-01-07T02:44:56Z

💔 Build Failed

Buildkite Build
Commit: f7b66f5

Failed CI Steps

Quick Checks

History

💔 Build #264574 failed 747e41d
💚 Build #264102 succeeded 011c7e3
💚 Build #263832 succeeded 05c1685
💔 Build #263740 failed 96fcf4b
💔 Build #263464 failed f5f5a0b

cc @YulNaumenko

kibanamachine · 2025-01-07T04:22:37Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12645144553

kibanamachine · 2025-01-07T04:27:45Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204885

Questions ?

Please refer to the Backport tool documentation

YulNaumenko · 2025-01-07T04:45:28Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ents from '@kbn/inference-endpoint-ui-common' (elastic#204885) 1. Migrated stack-connector `.inference` to use share UI components elastic#203204 2. Extended package `@kbn/inference-endpoint-ui-common` to support edit mode for the form of the connector, by adding the optional property `isEdit` to `InferenceServiceFormFields` component 3. Resolves flaky timing out test elastic#205129 --------- Co-authored-by: Samiul Monir <[email protected]> Co-authored-by: kibanamachine <[email protected]>

kibanamachine · 2025-01-08T04:49:03Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2025-01-09T05:48:55Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

Samiul-TheSoccerFan and others added 7 commits December 18, 2024 17:10

Adding package by extracting UI components from AI connector

1719e63

Integrating packaged library into inference management and add connec…

1c50825

…tor through flyout

Addig test subjects, comments and unit tests

eab4a68

Adding FTR tests for adding inference management ui

dc0465b

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

4d16097

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

8ed537a

…fix'

[AI Connector] Migrates AI inference Connector to use a shared compon…

93d448b

…ents from '@kbn/inference-endpoint-ui-common'

YulNaumenko mentioned this pull request Dec 19, 2024

[Search] Add Inference endpoint Flyout in Inference Management UI #203204

Merged

3 tasks

YulNaumenko added 2 commits December 30, 2024 12:24

cleanup

6499af2

YulNaumenko self-assigned this Dec 30, 2024

YulNaumenko added 8.18 candidate v8.18.0 backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes labels Dec 30, 2024

YulNaumenko marked this pull request as ready for review December 30, 2024 20:31

YulNaumenko requested review from a team as code owners December 30, 2024 20:31

kibanamachine and others added 5 commits December 30, 2024 20:41

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

be6ea81

removed labels

c201d79

Merge branch 'ai-connector-uses-shared-ui-components' of github.com:Y…

f5f5a0b

…ulNaumenko/kibana into ai-connector-uses-shared-ui-components

Merge branch 'main' into ai-connector-uses-shared-ui-components

96fcf4b

fixed task type on edit

05c1685

stephmilovic approved these changes Jan 2, 2025

View reviewed changes

adcoelho approved these changes Jan 3, 2025

View reviewed changes

Merge branch 'main' into ai-connector-uses-shared-ui-components

011c7e3

ymao1 reviewed Jan 3, 2025

View reviewed changes

Merge branch 'main' into ai-connector-uses-shared-ui-components

19de8d9

pgayvallet approved these changes Jan 6, 2025

View reviewed changes

Samiul-TheSoccerFan approved these changes Jan 6, 2025

View reviewed changes

removed get providers from connectors and uses the common hook from t…

1be7407

…he package

YulNaumenko requested a review from a team as a code owner January 7, 2025 00:12

YulNaumenko and others added 7 commits January 6, 2025 16:12

Merge branch 'main' into ai-connector-uses-shared-ui-components

37c2517

[CI] Auto-commit changed files from 'node scripts/notice'

60df2fa

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

cadcb90

[CI] Auto-commit changed files from 'node scripts/styled_components_m…

747e41d

…apping'

fixed build fail

8955abd

Merge branch 'ai-connector-uses-shared-ui-components' of github.com:Y…

fce116f

…ulNaumenko/kibana into ai-connector-uses-shared-ui-components

[CI] Auto-commit changed files from 'node scripts/notice'

f7b66f5

translations fix

713e039

YulNaumenko enabled auto-merge (squash) January 7, 2025 02:58

YulNaumenko merged commit 47b19ba into elastic:main Jan 7, 2025
8 checks passed

kibanamachine added the v9.0.0 label Jan 7, 2025

YulNaumenko mentioned this pull request Jan 7, 2025

[8.x] [AI Connector] Migrates AI inference Connector to use a shared components from '@kbn/inference-endpoint-ui-common' (#204885) #205671

Open

This was referenced Jan 7, 2025

[Security Solution] Add Threat Match rule specific editable fields #200308

Merged

[Stack Connectors][Microsoft Defender] Adds new connector for Microsoft Defender for Endpoint #203183

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AI Connector] Migrates AI inference Connector to use a shared components from '@kbn/inference-endpoint-ui-common' #204885

[AI Connector] Migrates AI inference Connector to use a shared components from '@kbn/inference-endpoint-ui-common' #204885

YulNaumenko commented Dec 19, 2024 •

edited by kibanamachine

Loading

stephmilovic left a comment

ymao1 Jan 3, 2025

Samiul-TheSoccerFan left a comment

elasticmachine commented Jan 7, 2025 •

edited

Loading

kibanamachine commented Jan 7, 2025

kibanamachine commented Jan 7, 2025

YulNaumenko commented Jan 7, 2025

kibanamachine commented Jan 8, 2025

kibanamachine commented Jan 9, 2025

[AI Connector] Migrates AI inference Connector to use a shared components from '@kbn/inference-endpoint-ui-common' #204885

[AI Connector] Migrates AI inference Connector to use a shared components from '@kbn/inference-endpoint-ui-common' #204885

Conversation

YulNaumenko commented Dec 19, 2024 • edited by kibanamachine Loading

stephmilovic left a comment

Choose a reason for hiding this comment

ymao1 Jan 3, 2025

Choose a reason for hiding this comment

Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

elasticmachine commented Jan 7, 2025 • edited Loading

💔 Build Failed

Failed CI Steps

History

kibanamachine commented Jan 7, 2025

kibanamachine commented Jan 7, 2025

💔 All backports failed

Manual backport

Questions ?

YulNaumenko commented Jan 7, 2025

💚 All backports created successfully

Questions ?

kibanamachine commented Jan 8, 2025

kibanamachine commented Jan 9, 2025

YulNaumenko commented Dec 19, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Jan 7, 2025 •

edited

Loading