Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Attempt to fix flaky test in service_group_count.spec.ts #204543

Conversation

iblancof
Copy link
Contributor

@iblancof iblancof commented Dec 17, 2024

Summary

Fixes #201267

Before migrating the API tests to be deployment-agnostic, we had already seen some flaky results for this test (#197912). After completing the migration, the error occurred again.

This PR aims to fix the potential issue by ensuring that all existing alerts are cleared before creating the alerts used in the test case.

@iblancof iblancof added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.18.0 labels Dec 17, 2024
@iblancof iblancof self-assigned this Dec 17, 2024
@iblancof iblancof requested a review from a team as a code owner December 17, 2024 10:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7607

[✅] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.apm.serverless.config.ts: 50/50 tests passed.
[✅] x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.apm.stateful.config.ts: 50/50 tests passed.

see run history

…ostic-APM-API-Integration-Tests-x-pack-test-api_integration-deployment_agnostic-apis-observability-apm-service_groups-service_group_count-service_group_count-spec-ts
…ostic-APM-API-Integration-Tests-x-pack-test-api_integration-deployment_agnostic-apis-observability-apm-service_groups-service_group_count-service_group_count-spec-ts
…ostic-APM-API-Integration-Tests-x-pack-test-api_integration-deployment_agnostic-apis-observability-apm-service_groups-service_group_count-service_group_count-spec-ts
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #20 / PackagePolicyAgentsCell when multiple agent policies is disabled it should display add agent button if count is 0

Metrics [docs]

✅ unchanged

History

cc @iblancof

@iblancof iblancof merged commit 128739d into elastic:main Jan 7, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12649199872

@iblancof iblancof deleted the 201267-Stateful-Observability-Deployment-agnostic-APM-API-Integration-Tests-x-pack-test-api_integration-deployment_agnostic-apis-observability-apm-service_groups-service_group_count-service_group_count-spec-ts branch January 7, 2025 09:55
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2025
…ic#204543)

## Summary

Fixes elastic#201267

Before migrating the API tests to be deployment-agnostic, we had already
seen some flaky results for this test
(elastic#197912). After completing the
migration, the error occurred again.

This PR aims to fix the potential issue by ensuring that all existing
alerts are cleared before creating the alerts used in the test case.

Co-authored-by: jennypavlova <[email protected]>
(cherry picked from commit 128739d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 7, 2025
…204543) (#205691)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] Attempt to fix flaky test in service_group_count.spec.ts
(#204543)](#204543)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Irene
Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T09:54:39Z","message":"[APM]
Attempt to fix flaky test in service_group_count.spec.ts (#204543)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/201267\r\n\r\nBefore migrating
the API tests to be deployment-agnostic, we had already\r\nseen some
flaky results for this
test\r\n(#197912). After
completing the\r\nmigration, the error occurred again.\r\n\r\nThis PR
aims to fix the potential issue by ensuring that all existing\r\nalerts
are cleared before creating the alerts used in the test
case.\r\n\r\nCo-authored-by: jennypavlova
<[email protected]>","sha":"128739dc46f79457fb1848b4ef63c318cd1bb3f1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services","v8.18.0"],"title":"[APM]
Attempt to fix flaky test in
service_group_count.spec.ts","number":204543,"url":"https://github.com/elastic/kibana/pull/204543","mergeCommit":{"message":"[APM]
Attempt to fix flaky test in service_group_count.spec.ts (#204543)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/201267\r\n\r\nBefore migrating
the API tests to be deployment-agnostic, we had already\r\nseen some
flaky results for this
test\r\n(#197912). After
completing the\r\nmigration, the error occurred again.\r\n\r\nThis PR
aims to fix the potential issue by ensuring that all existing\r\nalerts
are cleared before creating the alerts used in the test
case.\r\n\r\nCo-authored-by: jennypavlova
<[email protected]>","sha":"128739dc46f79457fb1848b4ef63c318cd1bb3f1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204543","number":204543,"mergeCommit":{"message":"[APM]
Attempt to fix flaky test in service_group_count.spec.ts (#204543)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/201267\r\n\r\nBefore migrating
the API tests to be deployment-agnostic, we had already\r\nseen some
flaky results for this
test\r\n(#197912). After
completing the\r\nmigration, the error occurred again.\r\n\r\nThis PR
aims to fix the potential issue by ensuring that all existing\r\nalerts
are cleared before creating the alerts used in the test
case.\r\n\r\nCo-authored-by: jennypavlova
<[email protected]>","sha":"128739dc46f79457fb1848b4ef63c318cd1bb3f1"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Irene Blanco <[email protected]>
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
…ic#204543)

## Summary

Fixes elastic#201267

Before migrating the API tests to be deployment-agnostic, we had already
seen some flaky results for this test
(elastic#197912). After completing the
migration, the error occurred again.

This PR aims to fix the potential issue by ensuring that all existing
alerts are cleared before creating the alerts used in the test case.

Co-authored-by: jennypavlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.18.0 v9.0.0
Projects
None yet
5 participants