[kbn-grid-layout] EUI Visual Refresh Integration #204445

cqliu1 · 2024-12-16T16:48:58Z

Summary

Related to #203132.
Closes #204592.

This replaces all references to euiThemeVars in favor of the useEuiTheme hook in the kbn-grid-layout package.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

elasticmachine · 2024-12-18T05:21:06Z

Pinging @elastic/kibana-presentation (Team:Presentation)

Heenawter · 2024-12-18T15:23:55Z

packages/kbn-grid-layout/grid/grid_panel/drag_handle.tsx

+        top: -${euiTheme.size.l};
+        width: ${euiTheme.size.l};
+        height: ${euiTheme.size.l};
+        z-index: ${euiTheme.levels.mask}; // TODO: double check this


Do you still need to double check this?

packages/kbn-grid-layout/grid/drag_preview.tsx

Heenawter

Making some suggestions based on #204445 (comment) - this is what the resulting layout looks like:

packages/kbn-grid-layout/grid/grid_row/grid_row.tsx

packages/kbn-grid-layout/grid/grid_panel/drag_handle.tsx

Fix linting error [CI] Auto-commit changed files from 'node scripts/notice' [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Apply suggestions from code review Use backgroundLightAccentSecondary Co-authored-by: Hannah Mudge <[email protected]> [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Remove z-index from drag handle Remove z-index from drag handle Revert "Remove z-index from drag handle" This reverts commit e50e7da. Remove comment

cqliu1 · 2025-01-02T19:44:21Z

packages/kbn-grid-layout/grid/grid_panel/drag_handle.tsx

+        top: -${euiTheme.size.l};
+        width: ${euiTheme.size.l};
+        height: ${euiTheme.size.l};
+        z-index: ${euiTheme.levels.modal};


@Heenawter I restored the z-index and removed the comment

elasticmachine · 2025-01-02T21:14:58Z

💚 Build Succeeded

Buildkite Build
Commit: a313690

Metrics [docs]

✅ unchanged

History

💚 Build #263189 succeeded e50e7da
💚 Build #263055 succeeded babaaf3
💚 Build #262516 succeeded 11393e4
💔 Build #262048 failed 8271477
💔 Build #261659 failed b1fbd32

## Summary Related to elastic#203132. Closes [elastic#204592](elastic#204592). This replaces all references to euiThemeVars in favor of the useEuiTheme hook in the `kbn-grid-layout` package. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...

cqliu1 changed the title ~~[kbn-grid-layout] Replace euiThemeVars usage~~ [kbn-grid-layout] EUI Visual Refresh Integration Dec 17, 2024

cqliu1 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas EUI Visual Refresh labels Dec 17, 2024

cqliu1 marked this pull request as ready for review December 18, 2024 05:21

cqliu1 requested a review from a team as a code owner December 18, 2024 05:21

cqliu1 added Project:Collapsable Panels Related to the project for adding collapsable sections to Dashboards. release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels labels Dec 18, 2024

Heenawter reviewed Dec 18, 2024

View reviewed changes

packages/kbn-grid-layout/grid/grid_row/grid_row.tsx Outdated Show resolved Hide resolved

Heenawter reviewed Dec 18, 2024

View reviewed changes

packages/kbn-grid-layout/grid/grid_row/grid_row.tsx Outdated Show resolved Hide resolved

cqliu1 commented Dec 27, 2024

View reviewed changes

packages/kbn-grid-layout/grid/grid_panel/drag_handle.tsx Show resolved Hide resolved

cqliu1 requested review from a team as code owners January 2, 2025 19:11

cqliu1 force-pushed the borealis/kbn-grid-layout/replace-euiThemeVars-usage branch from e26b301 to a313690 Compare January 2, 2025 19:43

cqliu1 requested review from a team and removed request for a team January 2, 2025 19:43

cqliu1 commented Jan 2, 2025

View reviewed changes

Heenawter approved these changes Jan 3, 2025

View reviewed changes

cqliu1 removed the request for review from a team January 3, 2025 21:10

cqliu1 merged commit 2b9104c into elastic:main Jan 3, 2025
8 checks passed

cqliu1 added backport:skip This commit does not require backporting and removed backport:version Backport to applied version labels labels Jan 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kbn-grid-layout] EUI Visual Refresh Integration #204445

[kbn-grid-layout] EUI Visual Refresh Integration #204445

cqliu1 commented Dec 16, 2024 •

edited

Loading

elasticmachine commented Dec 18, 2024

Heenawter Dec 18, 2024

Heenawter left a comment

cqliu1 Jan 2, 2025

elasticmachine commented Jan 2, 2025

[kbn-grid-layout] EUI Visual Refresh Integration #204445

[kbn-grid-layout] EUI Visual Refresh Integration #204445

Conversation

cqliu1 commented Dec 16, 2024 • edited Loading

Summary

Checklist

Identify risks

elasticmachine commented Dec 18, 2024

Heenawter Dec 18, 2024

Choose a reason for hiding this comment

Heenawter left a comment

Choose a reason for hiding this comment

cqliu1 Jan 2, 2025

Choose a reason for hiding this comment

elasticmachine commented Jan 2, 2025

💚 Build Succeeded

Metrics [docs]

History

cqliu1 commented Dec 16, 2024 •

edited

Loading