Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security assistant] Update converations.cy.ts #204404

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
+9 −6
Draft

[Security assistant] Update converations.cy.ts #204404

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f7b33d0
Update converations.cy.ts
patrykkopycinski Dec 16, 2024
b865f2c
Merge branch 'main' of github.com:elastic/kibana into fix/update-conv…
patrykkopycinski Dec 16, 2024
38a11cf
unskip
patrykkopycinski Dec 16, 2024
328d050
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Dec 16, 2024
edadc28
Merge branch 'main' into fix/update-conversations-cypress
patrykkopycinski Dec 18, 2024
afc737c
Merge branch 'main' into fix/update-conversations-cypress
patrykkopycinski Dec 19, 2024
0b82893
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Dec 19, 2024
2cd4ae0
Merge branch 'main' into fix/update-conversations-cypress
patrykkopycinski Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions x-pack/test/security_solution_cypress/cypress/e2e/ai_assistant/conversations.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
RULE_MANAGEMENT_CONTEXT_DESCRIPTION,
} from '@kbn/security-solution-plugin/public/detections/pages/detection_engine/rules/translations';
import { EXPLAIN_THEN_SUMMARIZE_SUGGEST_INVESTIGATION_GUIDE_NON_I18N } from '@kbn/security-solution-plugin/public/assistant/content/prompts/user/translations';
import { NEW_CHAT } from '@kbn/elastic-assistant/impl/assistant/conversations/conversation_sidepanel/translations';
import {
assertConnectorSelected,
assertNewConversation,
Expand All @@ -19,7 +20,7 @@ import {
createNewChat,
selectConversation,
assertMessageSent,
assertConversationTitle,
assertNotConversationTitle,
typeAndSendMessage,
assertErrorResponse,
selectRule,
Expand Down Expand Up @@ -47,8 +48,7 @@ import {
} from '../../screens/ai_assistant';
import { visit, visitGetStartedPage } from '../../tasks/navigation';

// Failing: See https://github.com/elastic/kibana/issues/204167
describe.skip('AI Assistant Conversations', { tags: ['@ess', '@serverless'] }, () => {
describe('AI Assistant Conversations', { tags: ['@ess', '@serverless'] }, () => {
beforeEach(() => {
deleteConnectors();
deleteConversations();
Expand Down Expand Up @@ -150,11 +150,11 @@ describe.skip('AI Assistant Conversations', { tags: ['@ess', '@serverless'] }, (
visitGetStartedPage();
openAssistant();
createNewChat();
assertNewConversation(false, 'New chat');
assertNewConversation(false, NEW_CHAT);
assertConnectorSelected(azureConnectorAPIPayload.name);
typeAndSendMessage('hello');
assertMessageSent('hello');
assertConversationTitle('Unexpected API Error: - Connection error.');
assertNotConversationTitle(NEW_CHAT);
updateConversationTitle('Something else');
});
});
Expand Down
3 changes: 3 additions & 0 deletions x-pack/test/security_solution_cypress/cypress/tasks/assistant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@ export const assertNewConversation = (isWelcome: boolean, title: string) => {
export const assertConversationTitle = (title: string) =>
cy.get(CONVERSATION_TITLE + ' h2').should('have.text', title);

export const assertNotConversationTitle = (title: string) =>
cy.get(CONVERSATION_TITLE + ' h2').should('not.have.text', title);

export const assertSystemPromptSent = (message: string) => {
cy.get(CONVERSATION_MESSAGE).eq(0).should('contain', message);
};
Expand Down