Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing CY test in ai_assistant #204365

Closed
wants to merge 1 commit into from

Conversation

KDKHD
Copy link
Member

@KDKHD KDKHD commented Dec 16, 2024

Summary

This cypress test is using a connector with a dummy URL (goodurl.com). According to icann.org this URL was updated this morning (someone likely registered it) and now the domain is returning a response that can not be parsed causing the test to fail. It was expected that this URL would return an error response.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@KDKHD KDKHD marked this pull request as ready for review December 16, 2024 11:36
@KDKHD KDKHD requested a review from a team as a code owner December 16, 2024 11:36
@KDKHD KDKHD added bug Fixes for quality problems that affect the customer experience backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development Team:Security Generative AI Security Generative AI labels Dec 16, 2024
@KDKHD KDKHD added the release_note:skip Skip the PR/issue when compiling release notes label Dec 16, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@KDKHD
Copy link
Member Author

KDKHD commented Dec 17, 2024

Resolved here: #204404

@KDKHD KDKHD closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants