[Onboarding] [Stack] Add Onboarding experience into Stack #204351
+1,657
−612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcelroy
added
release_note:skip
…ibana into onboarding-stack-add-plugin
…ibana into onboarding-stack-add-plugin
…ibana into onboarding-stack-add-plugin
yansavitski
force-pushed
the
onboarding-stack-add-plugin
branch
from
cb0210a to
af6b879
Compare
yansavitski
force-pushed
the
onboarding-stack-add-plugin
branch
from
24542e5 to
735e3b5
Compare
yansavitski
force-pushed
the
onboarding-stack-add-plugin
branch
from
2a9efd9 to
a6f3b8f
Compare
yansavitski
force-pushed
the
onboarding-stack-add-plugin
branch
from
8a5eea6 to
1df4762
Compare
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
wayneseymour
approved these changes
Jan 7, 2025
sabarasaba
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Thanks for working on this @joemcelroy! Had an initial pass at the code and looks good, just have few questions about these two tests
| @@ -18,14 +18,14 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { | |||
| await pageObjects.common.navigateToApp('indexManagement'); | |||
| }); | |||
|
|
|||
| it('Navigates to the index details page from the home page', async () => { | |||
| it.skip('Navigates to the index details page from the home page', async () => { | |||
There was a problem hiding this comment.
Did this break because of the changes or is it still wip? It seems like an important test to have
There was a problem hiding this comment.
It constantly breaks because it can't load indexManagement page and supposed to be fixed in future tickets
Comment on lines
-91
to
-92
| await pageObjects.indexManagement.performIndexAction('flush'); | ||
| await testSubjects.click('indexDetailsBackToIndicesButton'); |
There was a problem hiding this comment.
Just for my own understanding, why are these actions not needed anymore?
There was a problem hiding this comment.
New searchIndex page has not flush function anymore :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
These changes are only targeting 9.0.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelines