Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency ignore to v7 (main) #203286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elastic-renovate-prod[bot]
Copy link
Contributor

@elastic-renovate-prod elastic-renovate-prod bot commented Dec 6, 2024

This PR contains the following updates:

Package Type Update Change
ignore devDependencies major ^5.3.0 -> ^7.0.0

Release Notes

kaelzhang/node-ignore (ignore)

v7.0.0

Compare Source

Minor feature

The primary feature introduced by 7.0.0 is the .checkIgnore() method, which is most equivalent to git check-ignore -v. And also it allows to pass {pattern, mark?} as the parameter of .add() so that we could imitate the mechanism of git check-ignore as:

ig.add({
  pattern: 'foo/*',
  mark: '60'
})

const {
  ignored,
  rule
} = checkIgnore('foo/')

if (ignored) {
  console.log(`.gitignore:${result}:${rule.mark}:${rule.pattern} foo/`)
}

// .gitignore:60:foo/* foo/

Potential Incompatibilities

The only situation that 7.0.0 might bring incompatibility is to .add() a < 7.0.0 instance into a >= 7.0.0 instance, which might occur when the current workspace has multiple node-ignore versions installed, please be careful.

const {anotherIgnoreInstance} = require('./ignore-6.0-instance')

// A 7.0.0 instance
ignore().add(anotherIgnoreInstance)

// It will break your code

Otherwise, in most cases, if you never do something above or there is only one version of node-ignore installed in the current workspace, it is quite safe to upgrade to 7.0.0.

v6.0.2

Compare Source

v6.0.1: 6.x (== 5.3.2)

Compare Source

6.x

  • The release of 6.x is due to a mistake.
  • Making an upgrade from 5.x to 6.x for now actually changes nothing and does no harm, everyone could just upgrade or ignore the version.
    • Actually 6.0.2 is 5.3.2
  • The next major release will be 7.0.0

v6.0.0

Compare Source

v5.3.2

Compare Source

v5.3.1

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@elastic-renovate-prod elastic-renovate-prod bot added backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team labels Dec 6, 2024
@elastic-renovate-prod elastic-renovate-prod bot requested a review from a team December 6, 2024 16:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@Ikuni17
Copy link
Contributor

Ikuni17 commented Dec 7, 2024

buildkite test this

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 7, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #89 / Agent policies fleet_agent_policies POST /api/fleet/agent_policies should create .fleet-policies document with inputs
  • [job] [logs] FTR Configs #89 / Agent policies fleet_agent_policies POST /api/fleet/agent_policies should create .fleet-policies document with inputs

Metrics [docs]

✅ unchanged

History

@elastic-renovate-prod elastic-renovate-prod bot changed the title Update dependency ignore to v6 (main) Update dependency ignore to v7 (main) Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants