Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kql] Cleanup types & remove usage of any #119251

Closed
wants to merge 48 commits into from

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Nov 19, 2021

Summary

Cleans up & adds proper types for KQL.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@lukasolson lukasolson marked this pull request as draft November 19, 2021 22:56
@lukasolson lukasolson marked this pull request as ready for review November 29, 2021 22:06
@lukasolson lukasolson requested review from Dosant and ppisljar December 6, 2021 21:28
@lukasolson lukasolson added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 v9.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Dec 6, 2021
@lukasolson lukasolson requested a review from a team as a code owner February 28, 2022 19:34
@kibana-ci
Copy link
Collaborator

kibana-ci commented Mar 30, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / findAndCleanupTasks should call the find function with proper parameters

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/es-query 159 207 +48
data 2844 2832 -12
total +36

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/es-query 1 0 -1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/es-query 11 22 +11
kibana 313 361 +48
total +59
Unknown metric groups

API count

id before after diff
@kbn/es-query 213 322 +109
data 3457 3427 -30
total +79

References to deprecated APIs

id before after diff
apm 32 29 -3
dataEnhanced 55 43 -12
total -15

Unreferenced deprecated APIs

id before after diff
@kbn/es-query 0 1 +1
data 58 55 -3
total -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@lukasolson lukasolson requested review from a team as code owners April 16, 2022 06:39
@lukasolson
Copy link
Member Author

Going to close this out and hopefully replace with several smaller PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:KQL KQL release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.