[Reporting/Tests] Consolidate test archives, move kbn objects to kbn_archiver #116528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
reporting/test-archives-consolidations
branch
from
f22511b to
a663bd6
Compare
tsullivan
force-pushed
the
reporting/test-archives-consolidations
branch
from
a663bd6 to
0133637
Compare
…ves-consolidations
tsullivan
changed the title
tsullivan
added
SharedUX/fix-it-week
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
jloleysens
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
LGTM @tsullivan , left a question about one of the data .load calls to check before merging 👍🏻
x-pack/test/reporting_api_integration/reporting_without_security/job_apis_csv_deprecated.ts
Outdated
Show resolved
Hide resolved
tsullivan
commented
Nov 2, 2021
x-pack/test/reporting_api_integration/reporting_and_security/network_policy.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Nov 3, 2021
…archiver (elastic#116528) * remove unused * remove kibana objects from reporting es_archives * import objects using kibanaServer for tests * consolidate ecommerce_kibana_spaces * self-review * fix nanos test * fix loading of reporting/ecommerce_kibana_spaces * fix csv snapshots * fix more csv tests * archive rename * consolidate canvas_disallowed_url archive * clean up snapshots * fix CSV tests * polish * remove unused * Update x-pack/test/reporting_api_integration/reporting_and_security/network_policy.ts
tsullivan
added a commit
that referenced
this pull request
Nov 4, 2021
…archiver (#116528) (#117440) * remove unused * remove kibana objects from reporting es_archives * import objects using kibanaServer for tests * consolidate ecommerce_kibana_spaces * self-review * fix nanos test * fix loading of reporting/ecommerce_kibana_spaces * fix csv snapshots * fix more csv tests * archive rename * consolidate canvas_disallowed_url archive * clean up snapshots * fix CSV tests * polish * remove unused * Update x-pack/test/reporting_api_integration/reporting_and_security/network_policy.ts
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #96268
This PR consolidates all the Kibana saved objects that were in various ES Archives and moves them to a single Kbn Archive referred to as
reporting/logsin the code.To access any of these saved objects from a test, use
reportingApi.initLogs()to install into the test cluster, andreportingApi.teardownLogs()to remove.