[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions #205726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluefinger
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
rmyz
approved these changes
Jan 7, 2025
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
|
alvarezmelissa87
approved these changes
Jan 8, 2025
|
Starting backport for target branches: 7.17, 8.16, 8.17, 8.x |
1 task
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Bluefinger
added a commit
to Bluefinger/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205726) ## Summary Updates Cytoscape to newer versions, requiring one change with some `removeListener` usage no longer being valid typing. Supersedes elastic#205444 ## How to test - Passes CI with no type errors or failed CI jobs for ML - Job Map or wherever cytoscape is being used on ML doesn't leak event listeners. - Usages in APM also do not break. (cherry picked from commit 7363f03) # Conflicts: # x-pack/solutions/observability/plugins/apm/public/components/app/service_map/cytoscape_options.ts # yarn.lock
Bluefinger
added a commit
to Bluefinger/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205726) ## Summary Updates Cytoscape to newer versions, requiring one change with some `removeListener` usage no longer being valid typing. Supersedes elastic#205444 ## How to test - Passes CI with no type errors or failed CI jobs for ML - Job Map or wherever cytoscape is being used on ML doesn't leak event listeners. - Usages in APM also do not break. (cherry picked from commit 7363f03) # Conflicts: # package.json # x-pack/plugins/observability_solution/apm/public/components/app/service_map/cytoscape_options.ts # yarn.lock
Bluefinger
added a commit
to Bluefinger/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205726) ## Summary Updates Cytoscape to newer versions, requiring one change with some `removeListener` usage no longer being valid typing. Supersedes elastic#205444 ## How to test - Passes CI with no type errors or failed CI jobs for ML - Job Map or wherever cytoscape is being used on ML doesn't leak event listeners. - Usages in APM also do not break. (cherry picked from commit 7363f03) # Conflicts: # package.json # x-pack/plugins/observability_solution/apm/public/components/app/service_map/cytoscape_options.ts # yarn.lock
Bluefinger
added a commit
to Bluefinger/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205726) ## Summary Updates Cytoscape to newer versions, requiring one change with some `removeListener` usage no longer being valid typing. Supersedes elastic#205444 ## How to test - Passes CI with no type errors or failed CI jobs for ML - Job Map or wherever cytoscape is being used on ML doesn't leak event listeners. - Usages in APM also do not break.
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Bluefinger
added a commit
that referenced
this pull request
Jan 8, 2025
…ons (#205726) (#205848) # Backport This will backport the following commits from `main` to `8.x`: - [[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)](#205726) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T09:16:17Z","message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions","number":205726,"url":"https://github.com/elastic/kibana/pull/205726","mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205726","number":205726,"mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}}]}] BACKPORT-->
Bluefinger
added a commit
that referenced
this pull request
Jan 8, 2025
…ions (#205726) (#205850) # Backport This will backport the following commits from `main` to `8.17`: - [[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)](#205726) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T09:16:17Z","message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions","number":205726,"url":"https://github.com/elastic/kibana/pull/205726","mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205726","number":205726,"mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}}]}] BACKPORT-->
Bluefinger
added a commit
that referenced
this pull request
Jan 8, 2025
…ions (#205726) (#205854) # Backport This will backport the following commits from `main` to `8.16`: - [[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)](#205726) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T09:16:17Z","message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions","number":205726,"url":"https://github.com/elastic/kibana/pull/205726","mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205726","number":205726,"mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}}]}] BACKPORT-->
Bluefinger
added a commit
that referenced
this pull request
Jan 8, 2025
…ions (#205726) (#205867) # Backport This will backport the following commits from `main` to `7.17`: - [[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)](#205726) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T09:16:17Z","message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions","number":205726,"url":"https://github.com/elastic/kibana/pull/205726","mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205726","number":205726,"mergeCommit":{"message":"[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726)\n\n## Summary\r\n\r\nUpdates Cytoscape to newer versions, requiring one change with some\r\n`removeListener` usage no longer being valid typing.\r\n\r\nSupersedes #205444\r\n\r\n## How to test\r\n\r\n- Passes CI with no type errors or failed CI jobs for ML\r\n- Job Map or wherever cytoscape is being used on ML doesn't leak event\r\nlisteners.\r\n- Usages in APM also do not break.","sha":"7363f03d81835f70f39caa27e7096b8a0361ae69"}}]}] BACKPORT-->
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Jan 8, 2025
…lastic#205726) ## Summary Updates Cytoscape to newer versions, requiring one change with some `removeListener` usage no longer being valid typing. Supersedes elastic#205444 ## How to test - Passes CI with no type errors or failed CI jobs for ML - Job Map or wherever cytoscape is being used on ML doesn't leak event listeners. - Usages in APM also do not break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates Cytoscape to newer versions, requiring one change with some
removeListenerusage no longer being valid typing.Supersedes #205444
How to test