-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Obs AI Assistant] Rename chat completion methods to align with LLM vendor terminology #205583
Comments
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
OpenAI calls this |
@dgieselaar I agree. |
Handing this over to @viduni94 since she is already working on it |
Thank you @sorenlouv |
Before publishing the docs for our public chat complete API, we need to make sure that the properties and API endpoint conform with up to date terminology. For example:
Relates to https://github.com/elastic/obs-ai-assistant-team/issues/193 |
Problem
The Obs AI Assistant exposes two chat completion methods:
chat
andcomplete
. These names don't accurately describe their behaviour and does not align with LLM vendor terminology. This makes it more difficult when getting started working with the AI Assistant as a developerThe primary difference between the two methods is that:
chat
only calls chat completion API oncecomplete
resolves function (tool) requests and will therefore recursively call the chat completion API. It does this by callingchat
under the hood.Solution
chat
tochatCompletion
.complete
torunTools
LLM Terminology
API endpoints
We should also consider renaming the API endpoints:
POST /internal/observability_ai_assistant/chat
toPOST /internal/observability_ai_assistant/chat/completion
POST /internal/observability_ai_assistant/chat/complete
to/internal/observability_ai_assistant/chat/completion/run_tools
POST /api/observability_ai_assistant/chat/complete
to/api/observability_ai_assistant/chat/run_tools
The text was updated successfully, but these errors were encountered: