-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Obs AI Assistant] Add alerts.spec.ts to serverless tests #205524
Labels
Team:Obs AI Assistant
Observability AI Assistant
Comments
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
viduni94
added a commit
to viduni94/kibana
that referenced
this issue
Jan 3, 2025
2 tasks
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jan 3, 2025
…astic#205530) Closes elastic#205524 ## Summary Adds the alerts.spec to serverless tests. It's skipped in MKI because of the LLM proxy. There is an open issue for this - elastic#192751 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit f7b9d15)
kibanamachine
added a commit
that referenced
this issue
Jan 3, 2025
…5530) (#205543) # Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] Add alerts test to serverless (#205524) (#205530)](#205530) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T21:01:05Z","message":"[Obs AI Assistant] Add alerts test to serverless (#205524) (#205530)\n\nCloses https://github.com/elastic/kibana/issues/205524\r\n\r\n## Summary\r\n\r\nAdds the alerts.spec to serverless tests. It's skipped in MKI because of\r\nthe LLM proxy. There is an open issue for this -\r\nhttps://github.com//issues/192751\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f7b9d15df44320f307b890534b0453d9fdcbb719","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Obs AI Assistant","backport:version","v8.18.0"],"title":"[Obs AI Assistant] Add alerts test to serverless (#205524)","number":205530,"url":"https://github.com/elastic/kibana/pull/205530","mergeCommit":{"message":"[Obs AI Assistant] Add alerts test to serverless (#205524) (#205530)\n\nCloses https://github.com/elastic/kibana/issues/205524\r\n\r\n## Summary\r\n\r\nAdds the alerts.spec to serverless tests. It's skipped in MKI because of\r\nthe LLM proxy. There is an open issue for this -\r\nhttps://github.com//issues/192751\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f7b9d15df44320f307b890534b0453d9fdcbb719"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205530","number":205530,"mergeCommit":{"message":"[Obs AI Assistant] Add alerts test to serverless (#205524) (#205530)\n\nCloses https://github.com/elastic/kibana/issues/205524\r\n\r\n## Summary\r\n\r\nAdds the alerts.spec to serverless tests. It's skipped in MKI because of\r\nthe LLM proxy. There is an open issue for this -\r\nhttps://github.com//issues/192751\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f7b9d15df44320f307b890534b0453d9fdcbb719"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this issue
Jan 7, 2025
…astic#205530) Closes elastic#205524 ## Summary Adds the alerts.spec to serverless tests. It's skipped in MKI because of the LLM proxy. There is an open issue for this - elastic#192751 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This test is missing from the serverless tests. We should add and make sure it works there (local serverless CI only is sufficient), and then we can add to the deployment agnostic tests as part of tests we skip in MKI #205194
The text was updated successfully, but these errors were encountered: