Skip to content

Commit

Permalink
[8.x] [Obs AI Assistant] Add alerts test to serverless (#205524) (#20…
Browse files Browse the repository at this point in the history
…5530) (#205543)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs AI Assistant] Add alerts test to serverless (#205524)
(#205530)](#205530)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Viduni
Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T21:01:05Z","message":"[Obs
AI Assistant] Add alerts test to serverless (#205524)
(#205530)\n\nCloses
https://github.com/elastic/kibana/issues/205524\r\n\r\n##
Summary\r\n\r\nAdds the alerts.spec to serverless tests. It's skipped in
MKI because of\r\nthe LLM proxy. There is an open issue for this
-\r\nhttps://github.com//issues/192751\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] The PR
description includes the appropriate Release Notes section,\r\nand the
correct `release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f7b9d15df44320f307b890534b0453d9fdcbb719","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Obs
AI Assistant","backport:version","v8.18.0"],"title":"[Obs AI Assistant]
Add alerts test to serverless
(#205524)","number":205530,"url":"https://github.com/elastic/kibana/pull/205530","mergeCommit":{"message":"[Obs
AI Assistant] Add alerts test to serverless (#205524)
(#205530)\n\nCloses
https://github.com/elastic/kibana/issues/205524\r\n\r\n##
Summary\r\n\r\nAdds the alerts.spec to serverless tests. It's skipped in
MKI because of\r\nthe LLM proxy. There is an open issue for this
-\r\nhttps://github.com//issues/192751\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] The PR
description includes the appropriate Release Notes section,\r\nand the
correct `release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f7b9d15df44320f307b890534b0453d9fdcbb719"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205530","number":205530,"mergeCommit":{"message":"[Obs
AI Assistant] Add alerts test to serverless (#205524)
(#205530)\n\nCloses
https://github.com/elastic/kibana/issues/205524\r\n\r\n##
Summary\r\n\r\nAdds the alerts.spec to serverless tests. It's skipped in
MKI because of\r\nthe LLM proxy. There is an open issue for this
-\r\nhttps://github.com//issues/192751\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] The PR
description includes the appropriate Release Notes section,\r\nand the
correct `release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f7b9d15df44320f307b890534b0453d9fdcbb719"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Viduni Wickramarachchi <[email protected]>
  • Loading branch information
kibanamachine and viduni94 authored Jan 3, 2025
1 parent 223c889 commit 8079dde
Showing 1 changed file with 93 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/

import { MessageAddEvent, MessageRole } from '@kbn/observability-ai-assistant-plugin/common';
import expect from '@kbn/expect';
import {
LlmProxy,
createLlmProxy,
} from '@kbn/test-suites-xpack/observability_ai_assistant_api_integration/common/create_llm_proxy';
import { FtrProviderContext } from '../../../common/ftr_provider_context';
import { getMessageAddedEvents, invokeChatCompleteWithFunctionRequest } from './helpers';
import {
createProxyActionConnector,
deleteActionConnector,
} from '../../../common/action_connectors';
import type { InternalRequestHeader, RoleCredentials } from '../../../../../../../shared/services';

export default function ApiTest({ getService }: FtrProviderContext) {
const supertest = getService('supertest');
const log = getService('log');
const svlUserManager = getService('svlUserManager');
const svlCommonApi = getService('svlCommonApi');
const observabilityAIAssistantAPIClient = getService('observabilityAIAssistantAPIClient');

describe('when calling the alerts function', function () {
// TODO: https://github.com/elastic/kibana/issues/192751
this.tags(['skipMKI']);
let roleAuthc: RoleCredentials;
let internalReqHeader: InternalRequestHeader;
let proxy: LlmProxy;
let connectorId: string;
let alertsEvents: MessageAddEvent[];

const start = 'now-100h';
const end = 'now';

before(async () => {
roleAuthc = await svlUserManager.createM2mApiKeyWithRoleScope('editor');
internalReqHeader = svlCommonApi.getInternalRequestHeader();
proxy = await createLlmProxy(log);
connectorId = await createProxyActionConnector({
supertest,
log,
port: proxy.getPort(),
roleAuthc,
internalReqHeader,
});

void proxy
.intercept('conversation', () => true, 'Hello from LLM Proxy')
.completeAfterIntercept();

const alertsResponseBody = await invokeChatCompleteWithFunctionRequest({
connectorId,
observabilityAIAssistantAPIClient,
functionCall: {
name: 'alerts',
trigger: MessageRole.Assistant,
arguments: JSON.stringify({ start, end }),
},
});

await proxy.waitForAllInterceptorsSettled();

alertsEvents = getMessageAddedEvents(alertsResponseBody);
});

after(async () => {
proxy.close();
await deleteActionConnector({ supertest, connectorId, log, roleAuthc, internalReqHeader });
await svlUserManager.invalidateM2mApiKeyWithRoleScope(roleAuthc);
});

// This test ensures that invoking the alerts function does not result in an error.
it('should execute the function without any errors', async () => {
const alertsFunctionResponse = alertsEvents[0];
expect(alertsFunctionResponse.message.message.name).to.be('alerts');

const parsedAlertsResponse = JSON.parse(alertsFunctionResponse.message.message.content!);

expect(parsedAlertsResponse).not.to.have.property('error');
expect(parsedAlertsResponse).to.have.property('total');
expect(parsedAlertsResponse).to.have.property('alerts');
expect(parsedAlertsResponse.alerts).to.be.an('array');
expect(parsedAlertsResponse.total).to.be(0);
expect(parsedAlertsResponse.alerts.length).to.be(0);
});
});
}

0 comments on commit 8079dde

Please sign in to comment.