Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add waitUntilLoadingHasFinished in failing tests #205485

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Add waitUntilLoadingHasFinished in failing tests #205485

merged 10 commits into from
Jan 8, 2025
+31 −51

Conversation

SoniaSanzV
Copy link
Contributor

@SoniaSanzV SoniaSanzV commented Jan 3, 2025 •
edited by kibanamachine
Loading

Fixes: #205535
Fixes: #205514
Fixes: #205498
Fixes: #205464
Fixes: #205456
Fixes: #205453
Fixes: #205450
Fixes: #205412
Fixes: #205410
Fixes: #205401
Fixes: #205400
Fixes: #205399
Fixes: #205350
Fixes: #205349
Fixes: #205316
Fixes: #205288
Fixes: #205287

Summary

It seems that the step tabs are not loading fast enough for the tests to find the expected element in a bunch of test. This PR attempt to fix it. It also adds the data-test-subj="indexModeValue" tag in TabSummary that was missing.

@SoniaSanzV SoniaSanzV added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 3, 2025
@SoniaSanzV SoniaSanzV self-assigned this Jan 3, 2025
@SoniaSanzV SoniaSanzV requested a review from a team as a code owner January 3, 2025 12:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 700.9KB 701.0KB +31.0B

History

cc @SoniaSanzV

ElenaStoeva
ElenaStoeva reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @SoniaSanzV! Did you happen to check if the flakyness is fixed by running the Flaky test runner?

...agement/public/application/sections/home/template_list/template_details/tabs/tab_summary.tsx
@@ -234,7 +234,7 @@ export const TabSummary: React.FunctionComponent<Props> = ({ templateDetails })
defaultMessage="Index mode"
/>
</EuiDescriptionListTitle>
<EuiDescriptionListDescription>
<EuiDescriptionListDescription data-test-subj="indexModeValue">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test subject used somewhere?

Copy link
Contributor Author

@SoniaSanzV SoniaSanzV Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is used. So I don't know why they were passing when I was running them locally 🫠

@SoniaSanzV
Copy link
Contributor Author

Thanks for working on this @SoniaSanzV! Did you happen to check if the flakyness is fixed by running the Flaky test runner?

Dind't know that this tool existed! Really useful.

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7651

[❌] x-pack/test/functional/apps/index_management/config.ts: 2/25 tests passed.
[❌] x-pack/test_serverless/api_integration/test_suites/search/common_configs/config.group1.ts: 22/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group1.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group1.ts: 25/25 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7654

[❌] x-pack/test/functional/apps/index_management/config.ts: 170/200 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7658

[✅] x-pack/test/functional/apps/index_management/config.ts: 50/50 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group1.ts: 50/50 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group1.ts: 48/50 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group1.ts: 50/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7662

[✅] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group1.ts: 200/200 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7664

[✅] x-pack/test_serverless/functional/test_suites/search/common_configs/config.group1.ts: 200/200 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7663

[✅] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group1.ts: 200/200 tests passed.

see run history

ElenaStoeva
ElenaStoeva approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @SoniaSanzV!

@SoniaSanzV SoniaSanzV merged commit bcdf942 into elastic:main Jan 8, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12669101908

@SoniaSanzV SoniaSanzV deleted the fix_logsdb_tests branch January 8, 2025 10:52
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 8, 2025
@SoniaSanzV
Add waitUntilLoadingHasFinished in failing tests (elastic#205485)
8e6292c 
Fixes: elastic#205535
Fixes: elastic#205514
Fixes: elastic#205498
Fixes: elastic#205464
Fixes: elastic#205456
Fixes: elastic#205453
Fixes: elastic#205450
Fixes: elastic#205412
Fixes: elastic#205410
Fixes: elastic#205401
Fixes: elastic#205400
Fixes: elastic#205399
Fixes: elastic#205350
Fixes: elastic#205349
Fixes: elastic#205316
Fixes: elastic#205288
Fixes: elastic#205287

## Summary
It seems that the step tabs are not loading fast enough for the tests to
find the expected element in a [bunch of
test](https://github.com/elastic/kibana/issues?q=is%3Aopen%20label%3A%22Team%3AKibana%20Management%22%20label%3A%22failed-test%22%20created%3A%3E%40today-1w%20).
This PR attempt to fix it. It also adds the
`data-test-subj="indexModeValue"` tag in `TabSummary` that was missing.

(cherry picked from commit bcdf942)
@kibanamachine kibanamachine mentioned this pull request Jan 8, 2025
Open
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

Assignees

@SoniaSanzV SoniaSanzV

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/index_management/index_templates_tab/index_template_tab·ts - Index Management app Index Management: index templates tab Index template tab "after each" hook for "can create an index template with data retention" Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/index_management/index_templates_tab/index_template_tab·ts - Index Management app Index Management: index templates tab Index template tab can create an index template with data retention Failing test: Serverless Security Functional Tests - Common Group 1.x-pack/test_serverless/functional/test_suites/common/management/index_management/data_streams·ts - Serverless Common UI - Management Index Management Data Streams Modify data streams index mode allows to upgrade data stream from time series to logsdb index mode Failing test: Serverless Security Functional Tests - Common Group 1.x-pack/test_serverless/functional/test_suites/common/management/index_management/index_templates·ts - Serverless Common UI - Management Index Management Index Templates Create index template can create an index template with logsdb index mode Failing test: Serverless Observability Functional Tests - Common Group 1.x-pack/test_serverless/functional/test_suites/common/management/index_management/data_streams·ts - Serverless Common UI - Management Index Management Data Streams Modify data streams index mode allows to upgrade data stream from standard to logsdb index mode
Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/index_management/data_streams_tab/data_streams_tab·ts - Index Management app Index Management: data streams tab Data streams tab Modify data streams index mode allows to downgrade data stream from logsdb to standard index mode Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/index_management/index_templates_tab/index_template_tab·ts - Index Management app Index Management: index templates tab Index template tab can create an index template with logsdb index mode Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/index_management/index_templates_tab/index_template_tab·ts - Index Management app Index Management: index templates tab Index template tab "after each" hook for "can create an index template with logsdb index mode" Failing test: Serverless Observability Functional Tests - Common Group 1.x-pack/test_serverless/functional/test_suites/common/management/index_management/data_streams·ts - Serverless Common UI - Management Index Management Data Streams Modify data streams index mode allows to downgrade data stream from logsdb to time series index mode Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/index_management/data_streams_tab/data_streams_tab·ts - Index Management app Index Management: data streams tab Data streams tab Modify data streams index mode allows to upgrade data stream from time series to logsdb index mode
4 participants
@SoniaSanzV @elasticmachine @kibanamachine @ElenaStoeva