Skip to content

Commit

Permalink
[Infra] Fix failing test by changing read role permission (#205707)
Browse files Browse the repository at this point in the history
Closes #203740
## Summary

This PR fixes failing test by changing read role permission to include
`streams` and `apm`. As I mentioned in this
[comment](#203740 (comment))
I saw some 403 errors related to some `streams` and `apm` APIs requests
so this should fix the test as it was meant to test if the dashboards
tab behaves correctly based on the admin/read-only role.

However, we should think about a solution to those errors in case we
have this scenario (read-only user role without apm/streams access) and
have a better error message/explanation of what is missing instead of
only showing the error toasts - I saw that we reverted
(#202418) already a solution
(#200151) for APM because of
other issues but now that we also include the `streams`
(#200060) (not sure if we need to
do the request in infra but that's probably a different discussion) it's
something we can revisit at one point to improve the user experience.
  • Loading branch information
jennypavlova authored Jan 7, 2025
1 parent d86a966 commit 6fc90d0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions x-pack/test/functional/apps/infra/hosts_view.ts
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,9 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
{
feature: {
infrastructure: ['read'],
apm: ['read'],
advancedSettings: ['read'],
streams: ['read'],
},
spaces: ['*'],
},
Expand Down

0 comments on commit 6fc90d0

Please sign in to comment.