Fix types

elastic · Jan 6, 2025 · 53b9f23 · 53b9f23
1 parent 327173a
commit 53b9f23
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 21 deletions.
diff --git a/.buildkite/scripts/pipelines/pull_request/pipeline.ts b/.buildkite/scripts/pipelines/pull_request/pipeline.ts
@@ -96,18 +96,6 @@ const getPipeline = (filename: string, removeSteps = true) => {
       pipeline.push(getPipeline('.buildkite/pipelines/pull_request/inventory_cypress.yml'));
     }
 
-    if (
-      (await doAnyChangesMatch([
-        /^x-pack\/solutions\/observability\/plugins\/observability_onboarding/,
-        /^x-pack\/platform\/plugins\/shared\/fleet/,
-      ])) ||
-      GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
-    ) {
-      pipeline.push(
-        getPipeline('.buildkite/pipelines/pull_request/observability_onboarding_cypress.yml')
-      );
-    }
-
     if (
       (await doAnyChangesMatch([/^x-pack\/solutions\/observability\/plugins\/profiling/])) ||
       GITHUB_PR_LABELS.includes('ci:all-cypress-suites')

diff --git a/...plugins/observability_onboarding/ui_tests/tests/custom_logs/install_elastic_agent.spec.ts b/...plugins/observability_onboarding/ui_tests/tests/custom_logs/install_elastic_agent.spec.ts
@@ -6,12 +6,16 @@
  */
 
 import { expect } from '@kbn/scout';
-import { test } from '../../fixtures';
+import { type ExtendedScoutTestFixtures, test } from '../../fixtures';
 
 const CUSTOM_INTEGRATION_NAME = 'mylogs';
 
-function setupPage({ isAdmin }) {
-  return async ({ browserAuth, pageObjects: { customLogsPage }, page }) => {
+function setupPage({ isAdmin }: { isAdmin: boolean }) {
+  return async ({
+    browserAuth,
+    pageObjects: { customLogsPage },
+    page,
+  }: ExtendedScoutTestFixtures) => {
     await browserAuth.loginAsAdmin();
     await customLogsPage.deleteIntegration(CUSTOM_INTEGRATION_NAME);
 
@@ -69,14 +73,10 @@ test.describe(
               }),
             });
           });
-
-          await setupPage({ isAdmin: true })({
-            browserAuth,
-            pageObjects: { customLogsPage },
-            page,
-          });
         });
 
+        test.beforeEach(setupPage({ isAdmin: true }));
+
         test('apiKey is not generated', async ({ pageObjects: { customLogsPage } }) => {
           await expect(customLogsPage.apiKeyCreateErrorCallout()).toBeVisible();
         });