feat(mockotlpserver): use diagnostic channels for passing parsed OTLP data to printers #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data to printers The HTTP and gRPC servers will now publish parsed OTLP data to diagnostics channels named 'otlp.v1.trace', etc. Then there is a simple Printer class which supports a subclass with 'printTrace' et al methods. Those will subscribe to the 'otlp.*' channels and print as needed. Multiple independent subscribers can be added. We can change the 'Printer' name later if something else make better sense. Using diagnostics_channel required bumping the min node to 14.17.0. The only current printer is the InspectPrinter.
david-luna
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP and gRPC servers will now publish parsed OTLP data to
diagnostics channels named 'otlp.v1.trace', etc.
Then there is a simple Printer class which supports a subclass
with 'printTrace' et al methods. Those will subscribe to the
'otlp.*' channels and print as needed.
Multiple independent subscribers can be added. We can change
the 'Printer' name later if something else make better sense.
Using diagnostics_channel required bumping the min node to 14.17.0.
The only current printer is the InspectPrinter.