Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instr-openai): lock package-lock file version to v3 #546

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

trentm
Copy link
Member

@trentm trentm commented Jan 15, 2025

This is the default lockfileVersion used npm v9 and later. Node v18,
our min-supported Node.js version, includes npm v10.

Setting this config should ensure that dependabot updates don't
revert the lockfileVersion back to 2.


An example of that dependabot switching back to version 2 is here: https://github.com/elastic/elastic-otel-node/pull/543/files#diff-9d4a71f54ee443bf35be8c8af1bea61586971a4b0eca5d2d2be9262804de42e0R4

This is the default lockfileVersion used npm v9 and later. Node v18,
our min-supported Node.js version, includes npm v10.

Setting this config should ensure that dependabot updates don't
revert the lockfileVersion back to 2.
@trentm trentm merged commit 060821f into main Jan 16, 2025
9 checks passed
@trentm trentm deleted the trentm/instr-openai-lockfileversionlock branch January 16, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants