Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependabot): drop separate 'monthly' block for updating some npm deps #292

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented Jul 17, 2024

Today I noticed a new check failure on the latest commit to main. It was to
dependabot.yml. The failure:

Your .github/dependabot.yml contained invalid details
Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'. Ecosystem 'npm' has overlapping directories.

I don't know if this is a new constraint or was just not noticed before.
I am hoping dropping the 'monthly' block here will suffice. We will
just deal with aws-sdk updates weekly, distracting though that will be.

…m deps

Today I noticed a new check failure on the latest commit to main. It was to
dependabot.yml. The failure:
> Your .github/dependabot.yml contained invalid details
> Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'. Ecosystem 'npm' has overlapping directories.

I don't know if this is a new constraint or was just not noticed before.
I am hoping dropping the 'monthly' block here will suffice. We will
just deal with aws-sdk updates weekly, distracting though that will be.
@trentm trentm requested a review from david-luna July 17, 2024 22:08
@trentm trentm self-assigned this Jul 17, 2024
@trentm
Copy link
Member Author

trentm commented Jul 17, 2024

Link to the workflow run with the failure:
https://github.com/elastic/elastic-otel-node/runs/27586260424

@trentm trentm merged commit 5889a61 into main Jul 23, 2024
13 checks passed
@trentm trentm deleted the trentm/dependabot-new-uniqueness-constraint branch July 23, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants