Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preview workflow #279

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Add preview workflow #279

merged 7 commits into from
Jan 23, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jan 21, 2025 •
edited
Loading

Details

Add deployment of preview environments on a PR

Follow-ups

  • Deploy static preview for main branch
  • Create similar action for consumers

@reakaleek reakaleek added the automation packaging, ci/cd. label Jan 21, 2025
Mpdreamz
Mpdreamz reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general comments (realizing this is a draft).

@reakaleek reakaleek force-pushed the feature/preview-build branch from 9657bdb to c0a2f5b Compare January 22, 2025 22:52
@elastic elastic deleted a comment from github-actions bot Jan 22, 2025
@reakaleek reakaleek self-assigned this Jan 22, 2025
@reakaleek reakaleek marked this pull request as ready for review January 22, 2025 22:55
@reakaleek reakaleek requested review from a team, Mpdreamz and bmorelli25 January 22, 2025 22:55
Mpdreamz
Mpdreamz reviewed Jan 23, 2025
View reviewed changes
.github/workflows/pr.yml Outdated Show resolved Hide resolved
Mpdreamz
Mpdreamz requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits, can't wait to merge this in though so awesome!

Mpdreamz
Mpdreamz reviewed Jan 23, 2025
View reviewed changes
.github/workflows/preview.yml
deploy:
runs-on: ubuntu-latest
steps:
- name: Create Deployment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary for this PR but we might want to protect this to only run if doc changes are part of the PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention for this preview was not to create a preview of the docs only, but actually also a preview of changes within the docs-builder codebase.

@reakaleek reakaleek requested a review from Mpdreamz January 23, 2025 11:33
Mpdreamz
Mpdreamz reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reakaleek reakaleek requested a review from Mpdreamz January 23, 2025 14:00
@reakaleek reakaleek merged commit 88a4c2d into main Jan 23, 2025
5 checks passed
@reakaleek reakaleek deleted the feature/preview-build branch January 23, 2025 14:03
@reakaleek reakaleek mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

@bmorelli25 bmorelli25 Awaiting requested review from bmorelli25

Assignees

@reakaleek reakaleek

Labels
automation packaging, ci/cd.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reakaleek @Mpdreamz @bmorelli25