Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link appearance in code #260

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Fix link appearance in code #260

merged 3 commits into from
Jan 17, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jan 16, 2025 •
edited
Loading

Closes #219

Markdown

`code`
[`link`](modules-threadpool.md#node.processors)
`code`[`link`](modules-threadpool.md#node.processors)`code`
`code`[`link`](modules-threadpool.md#node.processors)
[`link`](modules-threadpool.md#node.processors)`code`

Thread pool type is `fixed` with a size of `int((`[`# of allocated processors`](modules-threadpool.md#node.processors)` * 3) / 2) + 1`, and queue_size of `1000`.

Result

image

@reakaleek reakaleek mentioned this pull request Jan 16, 2025
Closed
3 tasks
@reakaleek reakaleek added the fix label Jan 16, 2025
@reakaleek reakaleek self-assigned this Jan 16, 2025
@reakaleek reakaleek requested a review from a team January 16, 2025 23:24
@reakaleek reakaleek marked this pull request as ready for review January 16, 2025 23:24
bmorelli25
bmorelli25 reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on implementation, but the result looks good!

@reakaleek reakaleek requested a review from Mpdreamz January 17, 2025 11:30
Mpdreamz
Mpdreamz approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's put our custom css in custom.css

@reakaleek
Copy link
Member Author

Awesome, let's put our custom css in custom.css

cdb901b

@reakaleek reakaleek enabled auto-merge (squash) January 17, 2025 11:43
@reakaleek reakaleek disabled auto-merge January 17, 2025 11:44
@reakaleek reakaleek merged commit dd08e82 into main Jan 17, 2025
4 checks passed
@reakaleek reakaleek deleted the feature/links-inside-code branch January 17, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 left review comments

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

@reakaleek reakaleek

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS bug on links inside of code-formatted text
3 participants
@reakaleek @Mpdreamz @bmorelli25