Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'continue-on-error' input in publish action #210

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Mpdreamz
Copy link
Member

This adds an optional 'continue-on-error' input to the publish action. It allows the workflow to proceed even if documentation building fails, based on the provided value. Defaults to 'false' to maintain the current behavior.

This adds an optional 'continue-on-error' input to the publish action. It allows the workflow to proceed even if documentation building fails, based on the provided value. Defaults to 'false' to maintain the current behavior.
Copy link
Member

@reakaleek reakaleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate a bit more on this?

if the build fails, what will be deployed to pages?

@Mpdreamz
Copy link
Member Author

if the build fails, what will be deployed to pages?

We will always convert all the pages to the output, so we'll always deploy a complete docset. If this option is set it might not be one that validates though.

@reakaleek
Copy link
Member

if the build fails, what will be deployed to pages?

We will always convert all the pages to the output, so we'll always deploy a complete docset. If this option is set it might not be one that validates though.

Thanks for the explanation!

@Mpdreamz
Copy link
Member Author

This is a temporary feature while folks are migrating over. Will kill this feature afterwards since we don't want bad links.json to be published 💥

@Mpdreamz Mpdreamz merged commit a0c1284 into main Jan 15, 2025
5 of 7 checks passed
@Mpdreamz Mpdreamz deleted the feature/publish-ignore-errors-action branch January 15, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants