#972: add trustInsecureDownloadRoot parameter to plugins #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While adding unit tests by default, a bug was discovered when downloading via proxy with BasicAuth. This has also been fixed.
sdoeringNew
force-pushed
the
issue_972
branch
from
7e2aadc to
cbee747
Compare
|
@sdoeringNew thank you so much for this. I was banging my head on my desk for days trying to bypass some cert issues and I was able to get passed it with this. |
|
Glad to here it. 👍 |
|
Hi, is there any progress on this? Thank you. |
crisu
approved these changes
Jun 23, 2023
-->Can you please let me know how did you resolve this issue. |
Shrishti217
approved these changes
Jan 12, 2024
|
Now it's approved, but still not merged. Please :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Different download roots for Node, NPM, Yarn, etc. can be specified.
Those download roots might have HTTPS connections with self signed certificate.
For all those connections an additional plugin configuration has been added.
It's called:
trustInsecureDownloadRootThis might solve issue #972. The issue description is more or less vague.
For me it fixed the local problem with self signed certificates.
Tests and Documentation
Of course, tests and documentation have been added.
And while adding tests a bug was discovered. Downloads via Proxy with BasicAuth did not work.
This has been fixed while at it.