Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DocumentWatcher): use Workspace.applyEdit for applying changes #372

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SunsetTechuila
Copy link

  • Use a meaningful title for the pull request.
  • Use meaningful commit messages.
  • Run tsc w/o errors (same as npm run compile).
  • Run npm run lint w/o errors.

fixes #330 and its duplicates

@SunsetTechuila
Copy link
Author

@christian-bromann

@SunsetTechuila
Copy link
Author

@jednano

p.s. sorry for tagging you both, but it looks like the pr would rot without that

@SunsetTechuila
Copy link
Author

@nrayburn-tech maybe you can take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong behaviour with insert_final_newline = true and "files.autoSave": "afterDelay"
1 participant