Remove thread sticky context feature #5436
Merged
+20
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Thread sticky context was introduced in Vert.x 4 in order to maintain callback ordering when submitting tasks from a non vertx thread. Vert.x 5 introduces the sticky event-loop feature that implements the same idea for shadow contexts. In addition shadow context references cannot be reasonnably maintained. Dropping sticky context support does not break the original intent of the feature and brings behavior consistency when deadling with foreign contexts. Changes: Drop stick context feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Thread sticky context was introduced in Vert.x 4 in order to maintain callback ordering when submitting tasks from a non vertx thread.
Vert.x 5 introduces the sticky event-loop feature that implements the same idea for shadow contexts.
In addition shadow context references cannot be reasonnably maintained.
Dropping sticky context support does not break the original intent of the feature and brings behavior consistency when deadling with foreign contexts.
Changes:
Drop stick context feature.